Fixes formatting of unknown host in DHCP leases table

[yubiuser]

By submitting this pull request, I confirm the following: ]}`

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)
• I have Signed Off all commits. (git commit --signoff)

---

What does this PR aim to accomplish?:

Fixes an issue raised on discourse https://discourse.pi-hole.net/t/unknown-clients-comes-up-as-i-unknown-i-for-dhcp-leases/35663 where unknown clients in the DHCP lease table are shown as <i>unknown</i>

Fixes #1513, Fixes #1524, Fixes #753

How does this PR accomplish the above?:

Uses htmlentities on host(name) before introducing formatting code for unknown hosts and removes htmlentities when string is printed.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/unknown-clients-comes-up-as-i-unknown-i-for-dhcp-leases/35663/13

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/dhcp-leases-show-up-as-i-unknown-i/38876/2

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/how-to-apply-unknown-host-in-dhcp-leases-table-from-github/40027/1

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-core-web-v5-2-and-ftl-v5-3-released/40909/1

[enonu]

Hello, I'm still seeing this in Pi-hole v5.8.1 FTL v5.13 Web Interface v5.10.1. Has there been a regression of some sort?

[blackliner]

Maybe this line is causing that? https://github.com/pi-hole/AdminLTE/blob/master/settings.php#L680

[yubiuser]

No, it was https://github.com/pi-hole/AdminLTE/blob/b57ff6aeec72e99f0226e339fcaf55b3567ee6ae/scripts/pi-hole/js/settings.js#L249.

This should be fixed by #2100 which was part of the latest release.