HTML code escaping into GUI

[arfbarky]

In raising this issue, I confirm the following: {please fill the checkboxes, e.g: [X]}

• I have read and understood the contributors guide.
• The issue I am reporting can be replicated.
• The issue I am reporting isn't a duplicate (see FAQs, closed issues, and open issues).

How familiar are you with the the source code relevant to this issue?:

1

---

Expected behavior:

A couple of places in the GUI should display normal text; in one case, the font should be italicized and in the other case it should display a single quote

Actual behavior:

In Settings -> DHCP under Current Leases, I see "<i>unknown</i>" ... for the other, under Group Management -> Clients, after adjusting an entries group membership and applying, the single quote is replaced by "&#039;" when the next entry still correctly displays the single quote.

Screenshots of the two issues in the GUI

Steps to reproduce:

It started behaving this way as soon as I updated to 5.1

Debug token provided by uploading pihole -d log:

https://tricorder.pi-hole.net/8wxv08x886

Troubleshooting undertaken, and/or other relevant information:

I have not attempted to fix this issue

[yubiuser]

This first issue (regarding the unknown) is addressed here
#1509

[github-actions]

This issue is stale because it has been open 30 days with no activity. Please comment or update this issue or it will be closed in 5 days.

[yubiuser]

Adding bug because the <i>unknown</i> is back in the recent versions. And the single quote is replaced by "'" should remind us that the whole escaping/unescaping needs a re-work

[yubiuser]

Fixed in https://discourse.pi-hole.net/t/pi-hole-ftl-v5-14-web-v5-11-and-core-v5-9-released/53529