Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable radix ESLint rule #1374

Merged
merged 2 commits into from
Jun 5, 2020
Merged

Enable radix ESLint rule #1374

merged 2 commits into from
Jun 5, 2020

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented May 25, 2020

Signed-off-by: XhmikosR [email protected]

By submitting this pull request, I confirm the following: {please fill any appropriate checkboxes, e.g: [X]}

{Please ensure that your pull request is for the 'devel' branch!}

  • I have read and understood the contributors guide, as well as this entire template.
  • I have made only one major change in my proposed changes.
  • I have commented my proposed changes within the code.
  • I have tested my proposed changes.
  • I am willing to help maintain this change if there are issues with it later.
  • I give this submission freely and claim no ownership.
  • It is compatible with the EUPL 1.2 license
  • I have squashed any insignificant commits. (git rebase)
  • I have Signed Off all commits. (git commit --signoff)

@DL6ER since most of the code is yours, I could use some help.

The reason for this is https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt#Description

@XhmikosR XhmikosR force-pushed the radix branch 3 times, most recently from 71473ad to 50a917d Compare May 30, 2020 06:36
@XhmikosR XhmikosR mentioned this pull request Jun 4, 2020
8 tasks
@DL6ER
Copy link
Member

DL6ER commented Jun 4, 2020

Checking this now. I'm 99.999997% sure without looking at any code that radix should be 10 everywhere.

@XhmikosR XhmikosR added this to the v5.1 milestone Jun 4, 2020
@XhmikosR XhmikosR marked this pull request as ready for review June 4, 2020 15:02
@XhmikosR XhmikosR requested review from DL6ER and PromoFaux June 4, 2020 15:03
@XhmikosR XhmikosR merged commit 68297b1 into devel Jun 5, 2020
@XhmikosR XhmikosR deleted the radix branch June 5, 2020 07:28
@PromoFaux PromoFaux mentioned this pull request Jul 5, 2020
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants