Improve filtering on table pages

[DL6ER]

By submitting this pull request, I confirm the following:

• I have read and understood the contributors guide, as well as this entire template.
• I have made only one major change in my proposed changes.
• I have commented my proposed changes within the code.
• I have tested my proposed changes, and have included unit tests where possible.
• I am willing to help maintain this change if there are issues with it later.
• I give this submission freely and claim no ownership.
• It is compatible with the EUPL 1.2 license
• I have squashed any insignificant commits. (git rebase)

---

What does this PR aim to accomplish?:

Improve filtering on table pages. This enables a whole set of new features, see https://discourse.pi-hole.net/t/explicit-search-in-pi-hole-admin-console/28893/16

How does this PR accomplish the above?:

Change on-click actions on query types, domain and client from searching to filtering

What documentation changes (if any) are needed to support this PR?:

None

[DL6ER]

I addressed the raised review points:

• The button text is not short and static. Filtering is obvious enough from the highlighted columns
• I fixed the highlight color. They got lost in the adjustments for the light/dark themes. The highlighting colors of both themes are now set up correctly (it is intentional to change them theme-wide).
• I added both click pointers as well as dynamic tooltips:
  
  
  (the cursor isn't shown in the screenshots, however, it is of pointer type.

[yubiuser]

Thanks I like it a lot.

[yubiuser]

Initially filtering on status and reply was not possible due to technical reasons. Later you added the ability.
Does this now also enable the ability to search these columns? If not possible maybe add "Type/Domain/Client" as light grey text in the search input field so users know that it is limited to those columns.

[DL6ER]

Initially filtering on status and reply was not possible due to technical reasons. Later you added the ability.

Where did I add this? 🤔
I don't think it is needed, there is a rather limited set of possibilities for these fields and filtering-on-click should be totally sufficient. Still, the placeholder is a good idea.

[yubiuser]

Where did I add this?

https://discourse.pi-hole.net/t/explicit-search-in-pi-hole-admin-console/28893/36?u=yubiuser
https://discourse.pi-hole.net/t/explicit-search-in-pi-hole-admin-console/28893/39?u=yubiuser

[DL6ER]

Ah, I see. This was a misunderstanding. Yes, filtering on click is possible, but not through the search. The new placeholder should clarify this. Thanks.

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/sort-query-list-show-specific-client-dropdown-all-piholed-ok/15039/3

[DL6ER]

@PromoFaux Kindly requesting re-approval.

[PromoFaux]

Functionally speaking, this works well.

Requested changes were made

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1

[pralor-bot]

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/extend-query-table-filtering-from-v5-1-to-long-term-data-query-log/35634/1

[reinstej-sci]

Were consequences of this change on mobile/tablet browsers considered? This has broken the ability to click to filter on mobile.