-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pi-hole.css #1097
Update pi-hole.css #1097
Conversation
1a2340c
to
1663759
Compare
I think I'm gonna redo this after we all agree on some sensible browserslistrc. There's no point in supporting IE < 9 or even 10, or Opera Mini since these should not work already anyway due to JS. |
@dschaper can we agree on a more realistic browserslistrc? Then I will update this and remove any obsolete vendor prefixes from our CSS. |
Sure, @PromoFaux which IE do we still need? |
IE10 and 11, though, 10 becomes EOL at the end of this month. I can't imagine there are too many enterprise environments out there running <11. |
I think a min of 11 is good. |
IMHO we should target IE >= 10. IE 9 might also work, but I cannot test it personally. Plus the normal evergreen browsers. See https://browsersl.ist/?q=defaults%2C+IE+%3E%3D+10%2C+not+ie_mob+%3C%3D+11 and play with it to visualize the browsers. |
If 10 is supportable then great. I was operating under the assumption that 11 would be uncomfortable to shim in but 10 would be like ripping off a band-aid. If it's not to much more then 10 would be great. |
It should work, but I cannot confirm if the current devel branch works with IE 10. As long as we don't use new features, we should be fine. |
1663759
to
81c44cb
Compare
This is ready for review. The browserslist config I used is added in package.json. I can add the needed tools to automate this if you guys want later (postcss-cli and autoprefixer) |
5180f42
to
9016149
Compare
Alright, I went ahead and added everything. Now everything is automated regarding CSS and JS, including CSS prefixes for our CSS but we still need to run autoprefixer ( |
96acbb1
to
5feea09
Compare
76918a7
to
52eb6fc
Compare
This is ready for review. |
f19042c
to
0332621
Compare
0332621
to
1731b26
Compare
Rebased |
1731b26
to
6394d3c
Compare
1ef4c66
to
6ac7e5f
Compare
6d72c0a
to
c48cf6c
Compare
@XhmikosR Is this one ready for review and merge? |
I think I need to do a couple more tests. |
a06c83c
to
ff3f46b
Compare
ff3f46b
to
8fe0735
Compare
8fe0735
to
76f5424
Compare
@PromoFaux : I think this is finally ready. I split the patches a bit, tighten the browserslist settings and it should be good to go after one more tests round :) |
76f5424
to
9d52e9f
Compare
* add browserslist settings in package.json * add prettier scripts for CSS and JS (JS is mainly for devel since xo handles this for us) * add autoprefixer to handle CSS prefixes for us (`npm run prefix`) Signed-off-by: XhmikosR <[email protected]>
* format code * use `background-color` instead of the `background` shorthand * use the `animation` shorthand * remove unneeded CSS prefixes Signed-off-by: XhmikosR <[email protected]>
Signed-off-by: XhmikosR <[email protected]>
9d52e9f
to
ba86bb8
Compare
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/pi-hole-5-1-released/35577/1 |
background-color
instead of thebackground
shorthandanimation
shorthandonly transition opacity and transform in the chart tooltipBy submitting this pull request, I confirm the following:
{please fill any appropriate checkboxes, e.g: [X]}
{Please ensure that your pull request is for the 'devel' branch!}
git rebase
)git commit --signoff
)This is untested
It will conflict with #1094 so I'll need to rebase this later. We might also want to wait until we land #1080 and #1079 so that we do this once for the CSS part.
Non-whitespace diff: https://github.com/pi-hole/AdminLTE/pull/1097/files?w=1