-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CHAOS TXT record to construct FTL's API URL #376
Conversation
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Seems to work as expected when running in the device itself. I tested without
which does not look overly nice but does the job, I guess. Not sure if you want to improve on this or not. Reading through the code, I was wondering if you want to include the explicit if [ -z "${SERVER}" ]; then as the other branch may fail here. It just didn't fail in my case because FTL is the local resolver of my Pi-hole (this isn't standard). Now the test result from a different machine:
This does not look right. Running with |
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Thank for your review. I addressed both remarks. |
Pinging @DL6ER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
I added 2 commits: first only moves the output, second should address the "null" device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR aim to accomplish?:
Use
CHAOS
TXT
record provided by FTL (pi-hole/FTL#1793) to construct the API URL. This adds HTTPS support to PADD as well.Uses the same logic implemented by pi-hole/pi-hole#5499
Supersedes #375
By submitting this pull request, I confirm the following:
git rebase
)