Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add
CHAOS TXT
records to dynamically get the available API ports:domain.api.ftl
will use the configured web domain, e.g. "https://pi.hole:443/api"local.api.ftl
will use the hard-coded stringlocalhost
instead of the domain, e.g., "https://localhost:443/api"api.ftl
is an alias/shortcut fordomain.api.ftl
Redirected ports and duplicates (e.g. defined for IPv4 and IPv6) are skipped. We include the port also when standard ports are used (i.e., 80 for
http
and443
forhttps
) as this simplifies the code. There is also nothing bad about being explicit.There is no round-robin implemented here - this record will always return the ports in their order of being defined in
webserver.port
Example:
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.