Fix/privacy levels regex filtering #417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your PR:
Please submit all pull requests against the
development
branch. Failure to do so will delay or deny your requestHow familiar are you with the codebase?:
10
Fix regex filtering when privacy levels is > 0. This fixes #414
When a new query comes in, we check if we know this domain already.
If so: We check against the regex filters. If one of the filters match, we inject the domain as blocked into our DNS cache.
If not: We continue.
When the same domains is queried another time, we don't evaluate the regex filters any more as we rely on that the query will be quickly replied to from cache.
This usually works fine, however, for a non-zero privacy level, all domains are only stored as
hidden
in FTL's memory. Accordingly, any subsequent query (after the first )is not validated against the regex filters any more as they all get the samedomainID
.This has been fixed.
As a consequence, you cannot lower the privacy level without restarting
pihole-FTL
!This template was created based on the work of
udemy-dl
.