Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare PHP 8.4 compatibility #634

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Declare PHP 8.4 compatibility #634

merged 1 commit into from
Nov 19, 2024
+1 −1

Conversation

andypost
Copy link
Contributor

Closes #624

Jean85
Jean85 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Jean85
Copy link
Contributor

Jean85 commented Nov 7, 2024

I can report that I'm successfully using master with no issues under PHP 8.4: facile-it/paraunit#279

@k0ka k0ka mentioned this pull request Nov 8, 2024
Merged
@stof
Copy link
Member

stof commented Nov 19, 2024

@andypost please also update the CI config to have a job running on PHP 8.4

@andypost
Copy link
Contributor Author

@stof there's already https://github.com/phpspec/prophecy/blob/master/.github/workflows/build.yml#L24-L25

but to move it above phpspec needs new release

@stof stof merged commit 0c72ccb into phpspec:master Nov 19, 2024
12 checks passed
@andypost andypost deleted the 624-allow-8.4 branch November 19, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@W0rma W0rma W0rma approved these changes

@Jean85 Jean85 Jean85 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP 8.4 support
4 participants
@andypost @Jean85 @stof @W0rma