Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.4 support #624

Closed
andypost opened this issue Apr 30, 2024 · 4 comments · Fixed by #634
Closed

PHP 8.4 support #624

andypost opened this issue Apr 30, 2024 · 4 comments · Fixed by #634
Labels
PHP8.4

Comments

@andypost
Copy link
Contributor

I started testing Drupal 11 with PHP 8.4 and faced issues because of https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

I did patch some code (will provide PR) but still getting deprecation warnings from mocks

Probably the \Prophecy\Doubler\ClassPatch\DisableConstructorPatch::apply() needs changes

    OK (6 tests, 154 assertions)
    
    Other deprecation notices (2)
    
      1x:
    Double\Drupal\Core\Cache\Context\CacheContextsManager\P1::__construct():
    Implicitly marking parameter $container as nullable is deprecated, the
    explicit nullable type must be used instead
        1x in VariationCacheTest::setUp from Drupal\Tests\Core\Cache
    
      1x:
    Double\Drupal\Core\Cache\Context\CacheContextsManager\P1::__construct():
    Implicitly marking parameter $contexts as nullable is deprecated, the
    explicit nullable type must be used instead
        1x in VariationCacheTest::setUp from Drupal\Tests\Core\Cache
andypost added a commit to skilld-labs/prophecy that referenced this issue Apr 30, 2024
@andypost
Fix deprecated nullable areguments phpspec#624
8eaa851
@andypost andypost mentioned this issue Apr 30, 2024
Merged
@stof stof added the PHP8.4 label Aug 21, 2024
@andypost andypost mentioned this issue Aug 21, 2024
Merged
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 21, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
657ae94
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 21, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
210c459
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 21, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
6a64111
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 21, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
07be4a2
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 22, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
a3f0761
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 29, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
ad41b07
andypost added a commit to skilld-labs/prophecy that referenced this issue Aug 29, 2024
@andypost
Fix generator for PHP >= 8.4 phpspec#624
d0aa1d9
@schakko schakko mentioned this issue Sep 13, 2024
Closed
@Jean85
Copy link
Contributor

Jean85 commented Oct 23, 2024

#625 seems to be the last standing PR needed to have full PHP 8.4 compat.

andypost added a commit to skilld-labs/prophecy that referenced this issue Oct 28, 2024
@andypost
Fix spec for PHP >= 8.4 phpspec#624
c1547e0
andypost added a commit to skilld-labs/prophecy that referenced this issue Oct 28, 2024
@andypost
Fix spec for PHP >= 8.4 phpspec#624
ea755c9
andypost added a commit to skilld-labs/prophecy that referenced this issue Oct 28, 2024
@andypost
Fix spec for PHP >= 8.4 phpspec#624
0e0aba3 
- make optional argument the last
- make sure nullable is generated
andypost added a commit to skilld-labs/prophecy that referenced this issue Oct 28, 2024
@andypost
Fix spec for PHP >= 8.4 phpspec#624
47933d2 
- finalname is not optional argument
- make sure nullable is generated
andypost added a commit to skilld-labs/prophecy that referenced this issue Oct 28, 2024
@andypost
Fix spec for PHP >= 8.4 phpspec#624
89fb3d1 
- fullname argument is not optional
- make sure nullable array is generated
stof added a commit that referenced this issue Oct 29, 2024
@stof
Merge pull request #625 from skilld-labs/624-implicitly-nullable-8.4
00954b1 
 Fix deprecated nullable areguments #624
@andypost
Copy link
Contributor Author

Now waiting for new release but looks it depends on compatible phpspec/phpspec release phpspec/phpspec#1472 (comment)

@andypost andypost mentioned this issue Oct 29, 2024
Merged
@andypost
Copy link
Contributor Author

andypost commented Nov 4, 2024

@stof last 8.4.0RC4 this week any chance to see compatible release next week? This is only Drupal dependency which reports incompatibility with 8.4

@stof stof closed this as completed in #634 Nov 19, 2024
@andypost
Copy link
Contributor Author

@stof Thank you a lot!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PHP8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Declare PHP 8.4 compatibility skilld-labs/prophecy
3 participants
@andypost @stof @Jean85