-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented interlace support for GD, Imagick, and Gmagick. #196
Implemented interlace support for GD, Imagick, and Gmagick. #196
Conversation
**/ | ||
public function interlace($type) | ||
{ | ||
$supportedInterlaceTypes = array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about defining it static like at https://github.com/avalanche123/Imagine/blob/develop/lib/Imagine/Imagick/Image.php#L673 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm happy to do that to help maintain consistency. :)
Thanks.
* | ||
* @return ImageInterface | ||
*/ | ||
public function interlace($type); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did notice that the Imagick and Gmagick objects call the interlace types scheme
, I wonder if it's worth changing $type
to scheme too.
ImageInterface::interlace($scheme);
- Added missing param for array_key_exists calls - Renamed $type to $scheme within ImageInterface::interlace
Strange, if I use GD to create a set of interlaced images with:-
If I then use ImageMagick's
I'll investigate further. |
Thanks, @anthonysterling, I'm merging this in. Sorry for the lack of responses, I'm quite busy these couple of weeks |
Implemented interlace support for GD, Imagick, and Gmagick.
I thought it best to raise my own PR for Interlace Support given PR #185 has been dormant for a month or so.
Apologies @vchrm.
This PR adds interlace support for the GD, Imagick, and Gmagick implementations. It still requires updated documentation and tests, as such, I would really appreciate some guidance on the best approach to add tests for this functionality.
I'm looking forward to having someone review this.
Thanks everyone.
Anthony.