Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progressive JPEG Support #59

Open
ghost opened this issue Sep 13, 2019 · 11 comments
Open

Progressive JPEG Support #59

ghost opened this issue Sep 13, 2019 · 11 comments

Comments

@ghost
Copy link

ghost commented Sep 13, 2019

I ran into a small aesthetic issue, I was wondering if it was possible to add support for progressive jpeg output.

I'm using a lazyloading image pattern that uses a super condensed version of the image with a blur effect on it, and then loads into the actual image.
Using pthumb has been working great for that, except that all of my progressive jpegs get turned into regular jpegs. The loading effect of the whole image loading like a printed ruins the whole effect.

Doing a small amount of research it looks like Imagine found a way to implement this here, I'm not well versed in PHP, so I wasn't really able to understand what exactly was going on in there.

Is this something that is possible to add?

@sepiariver
Copy link

Currently working on an update to Resizer. Should work with the 0.7.1 version of Imagine. What is your availability to help test? Thanks !

@ghost
Copy link
Author

ghost commented Sep 13, 2019

Oh nice! I don't have any projects currently that I can do testing on, but depending on when the test build is available, I might be able to use it later this month?

@sepiariver
Copy link

A new version of Resizer has been released that should handle this issue, if the Imagine library does what it says in the changelog.

@ghost
Copy link
Author

ghost commented Sep 16, 2019

great! Does that make it available to pthumb output filter/snippet, or will I have to make my own output filter?

@sepiariver
Copy link

Please see https://sepiariver.com/modx/resizer-update/

Update Resizer in Extras :)

@ghost
Copy link
Author

ghost commented Sep 16, 2019

I updated it as soon as I saw the email this morning :), I guess my question was more if I use [[*image:pthumb=^options^]] will there be an option there to take advantage of the interlacing? I skimmed through the options for Resizer and could find anything similar, I can also move this over to the resizer repo

@sepiariver
Copy link

Oh darn I didn’t realize it had to be exposed as an option. I’ve yet to even touch pThumb at all. My approach was to try to modernize the lower layers first.

@ghost
Copy link
Author

ghost commented Sep 17, 2019

Oh no worries! I seriously appreciate the modernization focus though

@sepiariver
Copy link

Despite what it says in the blog post, I’m currently working on getting Reductionist to Imagine 1.2.2 (found an approach that seems to work). Then will work back up the chain through Resizer to pThumb.

@ghost
Copy link
Author

ghost commented Sep 17, 2019

Cool! Can't wait to see the outcome. Thanks for all the hard work you're putting into this project :)

@excelerondesign
Copy link

had an account issue, and needed to start over so just retagging myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant