Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose errata for anonymous classes #1206

Closed
wants to merge 4 commits into from
Closed

Propose errata for anonymous classes #1206

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea64fce
Propose errata for anonymous classes
Jean85 Jan 24, 2020
5e00ebb
Revert change to chapter 4
Jean85 Jan 26, 2020
bc4824d
Add errata in the meta docs
Jean85 Jan 26, 2020
94f757b
Improve errata wording
Jean85 Jan 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions accepted/PSR-12-extended-coding-style-guide-meta.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,3 +209,8 @@ _**Note:** Order descending chronologically._

* [Inspiration Mailing List Thread](https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/php-fig/wh9avopSR9k)
* [Initial Mailing List PSR Proposal Thread](https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!topic/php-fig/MkFacLdfGso)

# 9. Errata and clarifications

* The code example for anonymous classes has ben fixed (see [#1206](https://github.com/php-fig/fig-standards/pull/1206)) because it was wrong; omitting parentheses after the `class` keyword should not be allowed, since it would be in contrast with what is prescribed for normal classes.
Jean85 marked this conversation as resolved.
Show resolved Hide resolved
Jean85 marked this conversation as resolved.
Show resolved Hide resolved

6 changes: 3 additions & 3 deletions accepted/PSR-12-extended-coding-style-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1050,7 +1050,7 @@ in the above section.
~~~php
<?php

$instance = new class {};
$instance = new class() {};
~~~

The opening brace MAY be on the same line as the `class` keyword so long as
Expand All @@ -1062,12 +1062,12 @@ interface.
<?php

// Brace on the same line
$instance = new class extends \Foo implements \HandleableInterface {
$instance = new class() extends \Foo implements \HandleableInterface {
// Class content
};

// Brace on the next line
$instance = new class extends \Foo implements
$instance = new class() extends \Foo implements
\ArrayAccess,
\Countable,
\Serializable
Expand Down