Propose errata for anonymous classes

[Jean85]

Reference ML discussion: https://groups.google.com/d/topic/php-fig/F0IVXx1LL_Q/discussion

[samdark]

@GrahamCampbell comment makes sense.

[KorvinSzanto]

I think adding the parenthesis to samples makes sense, but only if we also describe why in errata. Adding anonymous classes to section 4 doesn't seem like a helpful change given the confusion.

[Jean85]

I've added an errata paragraph, but I'm not to happy with that; any suggestion on how to rephrase that?

[Jean85]

I've committed a mix of @samdark & @PowerKiKi suggestions.

[mvorisek]

@Jean85 Ready to be merged?

[Jean85]

This needs to go through a Core Committee vote to be approved.

[mvorisek]

@Jean85 Is that already scheduled and when the outcome can be excepted?

[Jean85]

It's up to @KorvinSzanto as the editor of the PSR to approve and call the vote on this.

[mbessolov]

Hello everyone,

While it all looks nice and tidy without any constructor arguments, once they get introduced into the example, it goes haywire.

4.1 Extends and Implements
The extends and implements keywords MUST be declared on the same line as the class name.

Let's see how this plays with constructor arguments present:

$instance = new class($firstConstructorArgument, $secondArgument, $thirdArgument, $andOneMore) extends \Foo implements \HandleableInterface {

or as many of us work with object properties and getters, it aggravates the problem further:

class Sometest {
    public function testSomething()
    {
        $instance = new class($this->getSomething(), $this->somethingElse, $this->andTheThirdProperty(), $this->letsBreakDemeterLawToo()->getX()) extends \Foo implements \HandleableInterface {

While PSR-2 imposes only a soft limit of 120 characters on line length, and there is stricly speaking no problem from the PSR point of view, I think that enforcing extends to be on the same line as new class() makes it barely readable (in the first example the line length is 142 characters, and in the second example it is 192 characters including indentation).

In my opinion a clarification is needed that class in new class() extends is not really "the class name" (they are anonymous classes after all, not having names by definition) and extends and implements keywords may be on the line with the closing parenthesis of a multi-line list of constructor arguments like so:

$instance = new class(
    $foo,
    $bar
) extends \Foo implements \HandleableInterface {

Could this last code snippet be included as an example in addition to/instead of the current one?

[drupol]

What's the status of this ?

[Jean85]

There's noone pushing those kind of changes.

The main problem here is that we do not have a way to handle these changes in an iterating way: the language is evolving really fast (enum, union types, matches are just some of the new stuff) and the PSR process is "granitic", since a PSR is supposed to be immutable. We would need a "living document" kind of process, not the simple PSR way as of now, but we're out of ideas for now.

If someone has some idea on how to proceed, it's welcome to discuss that with us, so we can try to define a formal process and make these kind of adjustments easy.

[WinterSilence]

@Jean85 standard immutable, but extendable (for example, RFC standards).
i.e.

• independent extension: base standard PSR-12 extends by PSR-12.1 (added rules rules anonymous classes), PSR-12.2 (added rules for enum's and annotations) and etc.
• cumulative extension: base standard PSR-12 extends by PSR-12.1, PSR-12.1 extends by PSR-12.2 and etc.

[Crell]

There is no "extendable with sub-spec" process for PSRs. That's not a thing.

However, we do now have a PER process for evolving standards, and there is a working group for a Coding Standards PER to supplant PSR-12. So that's happening, just not here.

Closing this issue accordingly.

[WinterSilence]

@Crell

PER process for evolving standards

where I can read more about it?

[Crell]

https://www.php-fig.org/bylaws/per-workflow/

[WinterSilence]

@Crell voting to modernize deprecated code looks like strange