Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

ServiceWorker.js Folder Instead of File #2052

Closed
agieocean opened this issue Nov 10, 2017 · 10 comments
Closed

ServiceWorker.js Folder Instead of File #2052

agieocean opened this issue Nov 10, 2017 · 10 comments

Comments

@agieocean
Copy link

agieocean commented Nov 10, 2017

Expected Behaviour

ServiceWorker.js placed in root www directory on build

Actual Behaviour

ServiceWorker.js place in www/ServiceWorker.js/ServiceWorker.js

Reproduce Scenario (including but not limited to)

  1. Add plugin to project
  2. Build

Steps to Reproduce

Seen above

Platform

Browser

Cordova CLI version and cordova platform version

cordova --version                                    7.1.0
cordova platform version browser                     5.0.1

Plugin version

cordova plugin version | grep phonegap-plugin-push   2.0.0
@macdonst
Copy link
Member

@MaxLFarrell can you run cordova platforms so I can see what version of the browser platform you are using?

@agieocean
Copy link
Author

Installed platforms:
  android 6.3.0
  browser 5.0.1
Available platforms:
  blackberry10 ~3.8.0 (deprecated)
  ios ~4.5.1
  osx ~4.0.1
  ubuntu ~4.3.4 (deprecated)
  webos ~3.7.0
  windows ~5.0.0
  www ^3.12.0

@macdonst
Copy link
Member

@MaxLFarrell this is a bug in the newly release cordova-browser platform. I've create a JIRA issue for it at:

https://issues.apache.org/jira/browse/CB-13562

Can you please go vote for it there?

Once it gets fixed in the browser platform I will update this plugin to use the new version. Sadly, as of now I don't have a work around as adding the earlier cordova-browser platform is not possible.

@macdonst macdonst added bug and removed question labels Nov 10, 2017
@agieocean
Copy link
Author

Done, I have voted and am watching, thank you.

@macdonst
Copy link
Member

@MaxLFarrell thanks for reporting this, hopefully we can get it fixed quickly. Unfortunately my sample project had an older version of cordova-browser already installed so it slipped past me.

@macdonst
Copy link
Member

@MaxLFarrell bug got fixed in cordova-browser and as soon as their is a new release I'll update this plugin to use it as a dependency.

@agieocean
Copy link
Author

Great thank you!

@agieocean
Copy link
Author

Any update on this?

@macdonst
Copy link
Member

macdonst commented Jan 8, 2018

@MaxLFarrell working on it but, and I honestly can't believe this but it looks like we need to update cordova-lib.

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants