Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Commit

Permalink
🐛 Issue #2052: ServiceWorker.js Folder Instead of File
Browse files Browse the repository at this point in the history
  • Loading branch information
macdonst committed Feb 28, 2018
1 parent 6888467 commit f24aed6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"2.2.0": {
"cordova-ios": ">=4.5.0",
"cordova-android": ">=7.1.0",
"cordova-browser": ">=5.0.3",
"cordova": ">=7.1.0"
}
}
Expand Down
1 change: 1 addition & 0 deletions plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<engines>
<engine name="cordova" version=">=7.1.0"/>
<engine name="cordova-android" version=">=7.1.0"/>
<engine name="cordova-browser" version=">=5.0.3"/>

This comment has been minimized.

Copy link
@ntamas

ntamas Mar 1, 2018

Contributor

cordova-browser is not a supported default engine according to the Cordova docs. This line causes cordova plugin add phonegap-plugin-push to fail for version 2.2.0.

<engine name="cordova-ios" version=">=4.5.0"/>
</engines>
<platform name="android">
Expand Down

0 comments on commit f24aed6

Please sign in to comment.