hal/ia32: Add platformctls for ehci #625
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
275a399 to
436944c
Compare
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
436944c to
982afd5
Compare
agkaminski
reviewed
Dec 6, 2024
Comment on lines
+139
to
+142
|
|
||
| if ((osOwned == 0) && ((dv & (1 << 24)) == 0) && ((dv & (1 << 16)) != 0)) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ((osOwned == 0) && ((dv & (1 << 24)) == 0) && ((dv & (1 << 16)) != 0)) { | |
| break; | |
| } |
There was a problem hiding this comment.
These two conditionals are for handling two separate situations: first one is relevant when the OS asks the BIOS for ownership of the USB controller, second one is when the OS wants to relinquish the ownership and return it to the BIOS. These conditions check for the states of "HC BIOS Owned" and "HC OS Owned" semaphores, respectively, to see whether the ownership was obtained/moved as needed. Removing the second case would hang the caller indefinitely if osOwned == 0
All USB UHCI/OHCI/EHCI/XHCI controllers have the same class:subclass 0c:03 and need to be differentiated based on progif (e.g. 0x20 for EHCI) JIRA: RTOS-937
JIRA: RTOS-937
Allows for controlling the state of various pci device configuration registers JIRA: RTOS-937
adamgreloch
force-pushed
the
adamgreloch/RTOS-937
branch
from
982afd5 to
0ff94d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting up EHCI controller on ia32 requires a bit of talking to bios via PCI
JIRA: RTOS-937
Description
Motivation and Context
Types of changes
pctl_busmasterhas been removed. Its functionality is realized bypctl_pcicfg(pci_cfg_busmaster)How Has This Been Tested?
Checklist:
Special treatment