-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.15 bugfix release #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kecnry
commented
Jun 21, 2024
•
edited
Loading
edited
- Fix handling of include_times for RVs with compute_times/phases. [fix handling of include_times for rv with compute_times/phases #889]
- GPs on models computed in phase-space will be properly computed based on residuals in time space. [Compute model in phase before assessing GPs in time space #899]
- Fix units of requivfrac. [fix requivfrac units #894]
- Fix adopting mask_phases from lc_geometry. [fix bug in adopting mask_phases from lc_geometry #896]
- Fix population of wavelength array in load function for passbands. [Adding back the definition of self.wl to passband load() function #914]
- Temporarily cap numpy dependency < 2.0. [Impose numpy version cap to 2.0.0. #930]
- Fix installation of phoebe-server CLI script to launch from UI. [Re-added script installs. #929]
- Fix passing compute to export_solver with features attached. [Fix passing compute to export_solver with features attached #922]
- sigmas_lnf: change handling of noise-nuissance parameter for RVs to no longer depend on the RV amplitude. [Updated functionality for lnf_rv #901]
- Remove duplicated phoebe-server code. [remove legacy phoebe-server #940]
- Fix python 3.12+ support by updating invalid escape sequences. [Fixes invalid escape sequences #948]
- Improved precision in calculation of constraints. [Correction of constraints #945]
* When using Gaussian processes, the model can now be computed in phase space and the GPs will then be applied to the residuals in time space (check removed from run checks solver). * Added test to check that basic gps work when fitted with mcmc in phase space. * install celerite2 and emcee in CI --------- Co-authored-by: Kyle Conroy <[email protected]>
fix unit on requivfrac parameter (from optional constraint)
2 tasks
Update passbands.py Added back the definition of wl to passband load() function
It looks like failures are caused by numpy >= 2.0.0 (judged by this PR passing all tests). |
Imposed numpy < 2.0.0 in the build system.
During the setup.py->pyproject.toml transition in 2.4.12, installing phoebe-server and phoebe-autofig scripts was inadvertently removed. It has now been reintroduced to pyproject.toml.
fix bug exporting solver with features enabled
* updated _calculate_cf function to adjust lnf calculation for radial velocities. * add warning in run_checks if sigmas_lnf is set for an RV curve --------- Co-authored-by: Kyle Conroy <[email protected]>
Co-authored-by: Matthias Fabry <[email protected]>
Strings with invalid escape sequences raised a deprecation syntax warning in python 3.11 but a syntax error in 3.12+. All instances (at least the ones that present themselves at import time) have been fixed.
* Correction of constraints <- "%.17e" format. * Rebuilt default binaries. --------- Co-authored-by: Kyle Conroy <[email protected]>
aprsa
added a commit
that referenced
this pull request
Oct 8, 2024
commit 34281b8 Merge: 1584f6c 22fa0db Author: Kyle Conroy <[email protected]> Date: Mon Oct 7 15:16:16 2024 -0400 Merge 2.4.15 into release-2.5 commit 22fa0db Author: Kyle Conroy <[email protected]> Date: Mon Oct 7 11:20:56 2024 -0400 modified publish workflow (#952) * modified publish workflow using same as https://github.com/aprsa/ndpolator/blob/main/.github/workflows/on_release.yaml * address build wheel warnings * bump ubuntu runner to 24.04 * upgrade cibuildwheel * skip failing builds commit fbde243 Author: Kyle Conroy <[email protected]> Date: Thu Oct 3 15:48:13 2024 -0400 2.4.15 bugfix release (#907) * Fix handling of include_times for RVs with compute_times/phases. [#889] * GPs on models computed in phase-space will be properly computed based on residuals in time space. [#899] * Fix units of requivfrac. [#894] * Fix adopting mask_phases from lc_geometry. [#896] * Fix population of wavelength array in load function for passbands. [#914] * Temporarily cap numpy dependency < 2.0. [#930] * Fix installation of phoebe-server CLI script to launch from UI. [#929] * Fix passing compute to export_solver with features attached. [#922] * sigmas_lnf: change handling of noise-nuissance parameter for RVs to no longer depend on the RV amplitude. [#901] * Remove duplicated phoebe-server code. [#940] * Fix python 3.12+ support by updating invalid escape sequences. [#948] * Improved precision in calculation of constraints. [#945] --------- Co-authored-by: Kelly Hambleton (Prsa) <[email protected]> Co-authored-by: David Jones <[email protected]> Co-authored-by: Andrej Prsa <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Miroslav Broz <[email protected]> commit bf850e1 Author: Kyle Conroy <[email protected]> Date: Thu Oct 3 11:02:38 2024 -0400 release GH actions workflow (#949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.