Updated functionality for lnf_rv #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the base bugfix branch (#907) is also failing CI, so likely due to upstream changes. We can move forward with this if those errors are all the same, but then should probably try to get CI passing again before releasing. |
|
Confirmed that the failing tests were the same as on the base branch. @kmhambleton does the warning I added look reasonable to you (since this is a behavior change and we want to make sure anyone that was relying on the old behavior for some reason will see this change - we can remove the warning in the next minor release)? |
kecnry
approved these changes
Aug 28, 2024
Merged
kecnry
added a commit
that referenced
this pull request
Oct 3, 2024
* Fix handling of include_times for RVs with compute_times/phases. [#889] * GPs on models computed in phase-space will be properly computed based on residuals in time space. [#899] * Fix units of requivfrac. [#894] * Fix adopting mask_phases from lc_geometry. [#896] * Fix population of wavelength array in load function for passbands. [#914] * Temporarily cap numpy dependency < 2.0. [#930] * Fix installation of phoebe-server CLI script to launch from UI. [#929] * Fix passing compute to export_solver with features attached. [#922] * sigmas_lnf: change handling of noise-nuissance parameter for RVs to no longer depend on the RV amplitude. [#901] * Remove duplicated phoebe-server code. [#940] * Fix python 3.12+ support by updating invalid escape sequences. [#948] * Improved precision in calculation of constraints. [#945] --------- Co-authored-by: Kelly Hambleton (Prsa) <[email protected]> Co-authored-by: David Jones <[email protected]> Co-authored-by: Andrej Prsa <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Miroslav Broz <[email protected]>
aprsa
added a commit
that referenced
this pull request
Oct 8, 2024
commit 34281b8 Merge: 1584f6c 22fa0db Author: Kyle Conroy <[email protected]> Date: Mon Oct 7 15:16:16 2024 -0400 Merge 2.4.15 into release-2.5 commit 22fa0db Author: Kyle Conroy <[email protected]> Date: Mon Oct 7 11:20:56 2024 -0400 modified publish workflow (#952) * modified publish workflow using same as https://github.com/aprsa/ndpolator/blob/main/.github/workflows/on_release.yaml * address build wheel warnings * bump ubuntu runner to 24.04 * upgrade cibuildwheel * skip failing builds commit fbde243 Author: Kyle Conroy <[email protected]> Date: Thu Oct 3 15:48:13 2024 -0400 2.4.15 bugfix release (#907) * Fix handling of include_times for RVs with compute_times/phases. [#889] * GPs on models computed in phase-space will be properly computed based on residuals in time space. [#899] * Fix units of requivfrac. [#894] * Fix adopting mask_phases from lc_geometry. [#896] * Fix population of wavelength array in load function for passbands. [#914] * Temporarily cap numpy dependency < 2.0. [#930] * Fix installation of phoebe-server CLI script to launch from UI. [#929] * Fix passing compute to export_solver with features attached. [#922] * sigmas_lnf: change handling of noise-nuissance parameter for RVs to no longer depend on the RV amplitude. [#901] * Remove duplicated phoebe-server code. [#940] * Fix python 3.12+ support by updating invalid escape sequences. [#948] * Improved precision in calculation of constraints. [#945] --------- Co-authored-by: Kelly Hambleton (Prsa) <[email protected]> Co-authored-by: David Jones <[email protected]> Co-authored-by: Andrej Prsa <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Matthias Fabry <[email protected]> Co-authored-by: Miroslav Broz <[email protected]> commit bf850e1 Author: Kyle Conroy <[email protected]> Date: Thu Oct 3 11:02:38 2024 -0400 release GH actions workflow (#949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated _calculate_cf function to adjust lnf calculation for radial velocities. The noise nuisance parameter for rvs no longer contains the rv amplitude.
Closes #752 and #895
TODO: