Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout of RTL broken in Firefox 128 #1643

Closed
KatieWoe opened this issue Jul 9, 2024 · 7 comments
Closed

Layout of RTL broken in Firefox 128 #1643

KatieWoe opened this issue Jul 9, 2024 · 7 comments
Assignees
@jonathanolson
Labels
priority:2-high type:bug

Comments

@KatieWoe
Copy link

KatieWoe commented Jul 9, 2024

Found during phetsims/qa#1105, but occurs in published sims.
Between Firefox 127 and Firefox 128 the layout of rtl strings in sims was broken. They appear far right of where they should. This is both in the locale selection page and in the sim itself if those locales are chosen. Happens with both dynamic locale and non-dynamic locale.
ugh
wha
@zepumph
Copy link
Member

zepumph commented Jul 9, 2024

@kathy-phet @marlitas FYI. I believe that some investigation here should be a pretty high priority.

@marlitas
Copy link
Contributor

marlitas commented Jul 9, 2024

@zepumph I completely agree. It looks like @jonathanolson is looking at it already according to slack.

@jonathanolson
Copy link
Contributor

Reproducing. Also seems broken in Firefox nightly 130.0a1, so likely not temporary.

@jonathanolson
Copy link
Contributor

Appears to be specific to SVG, does not happen with rootRenderer=canvas.

@jonathanolson
Copy link
Contributor

Looks like one of the necessary components to this is the directional marks.

@jonathanolson
Copy link
Contributor

10 year old issue (https://bugzilla.mozilla.org/show_bug.cgi?id=1131192) led to me trying text-anchor="end". This results in the correct display of text when this issue occurs, so there might be a good possibility for an ugly workaround.

However this likely is... version specific.

jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
359abce 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
02c73ce 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/acid-base-solutions that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
c7066a7
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text workaround for Firefox, see #1643
f5b1619
jonathanolson added a commit to phetsims/area-builder that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
f679d73
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
04d8ffb 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/area-model-algebra that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
0f7927d
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
c069c69 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/area-model-decimals that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
dcf9b39
jonathanolson added a commit to phetsims/area-model-introduction that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
d80bed2
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
bca31fa 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/area-model-multiplication that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
eedfb39
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
1689878 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/arithmetic that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
fec45bb
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text workaround for Firefox, see #1643
781cc0a
jonathanolson added a commit to phetsims/atomic-interactions that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
4c9edcb
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text iterative stripping of embedding marks (and direction/text-a…
c783303 
…nchor added) workaround for Firefox, see #1643
jonathanolson added a commit to phetsims/balancing-act that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
20d6b4d
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text workaround for Firefox, see #1643
1a03c92
jonathanolson added a commit to phetsims/balancing-chemical-equations that referenced this issue Jul 9, 2024
@jonathanolson
updated dependencies.json for phetsims/scenery#1643
6ef96a4
jonathanolson added a commit that referenced this issue Jul 9, 2024
@jonathanolson
SVG text workaround for Firefox, see #1643
d261db3
jonathanolson added a commit to phetsims/number-play that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.8, phetsims/scenery#1643
3a7a466
jonathanolson added a commit to phetsims/ohms-law that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.4.27, phetsims/scenery#1643
07f689d
jonathanolson added a commit to phetsims/pendulum-lab that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.32, phetsims/scenery#1643
90a00a8
jonathanolson added a commit to phetsims/ph-scale that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.6.15, phetsims/scenery#1643
c11f911
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.5.18, phetsims/scenery#1643
dc8455d
jonathanolson added a commit to phetsims/ph-scale-basics that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.6.14, phetsims/scenery#1643
65bb9be
jonathanolson added a commit to phetsims/plinko-probability that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.33, phetsims/scenery#1643
a42b9f5
jonathanolson added a commit to phetsims/projectile-data-lab that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.3, phetsims/scenery#1643
950d616
jonathanolson added a commit to phetsims/projectile-motion that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.31, phetsims/scenery#1643
acf229e
jonathanolson added a commit to phetsims/projectile-sampling-distributions that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.3, phetsims/scenery#1643
8836d35
jonathanolson added a commit to phetsims/proportion-playground that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.30, phetsims/scenery#1643
8fbd393
jonathanolson added a commit to phetsims/quadrilateral that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.9, phetsims/scenery#1643
81cace9
jonathanolson added a commit to phetsims/ratio-and-proportion that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.2.13, phetsims/scenery#1643
70bb17d
jonathanolson added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.2.27, phetsims/scenery#1643
8848138
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.3.28, phetsims/scenery#1643
1793a07
jonathanolson added a commit to phetsims/resistance-in-a-wire that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.6.28, phetsims/scenery#1643
45b5b89
jonathanolson added a commit to phetsims/rutherford-scattering that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.25, phetsims/scenery#1643
307d34f
jonathanolson added a commit to phetsims/sound-waves that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.7, phetsims/scenery#1643
9a887d7
jonathanolson added a commit to phetsims/states-of-matter that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.2.19, phetsims/scenery#1643
fffb2d4
jonathanolson added a commit to phetsims/states-of-matter-basics that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.2.19, phetsims/scenery#1643
0d4115a
jonathanolson added a commit to phetsims/trig-tour that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.38, phetsims/scenery#1643
41d38e3
jonathanolson added a commit to phetsims/under-pressure that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.33, phetsims/scenery#1643
811d0f3
jonathanolson added a commit to phetsims/unit-rates that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.32, phetsims/scenery#1643
9fc6923
jonathanolson added a commit to phetsims/vector-addition that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.17, phetsims/scenery#1643
e760064
jonathanolson added a commit to phetsims/vector-addition-equations that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.0.17, phetsims/scenery#1643
6942a11
jonathanolson added a commit to phetsims/wave-interference that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 2.0.19, phetsims/scenery#1643
4105e95
jonathanolson added a commit to phetsims/wave-on-a-string that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.37, phetsims/scenery#1643
d26962c
jonathanolson added a commit to phetsims/waves-intro that referenced this issue Jul 13, 2024
@jonathanolson
Bumping version to 1.1.20, phetsims/scenery#1643
30114d0
@jonathanolson
Copy link
Contributor

This looks like it will likely be fixed in Firefox 130. MR workaround complete, so closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
priority:2-high type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jonathanolson @zepumph @KatieWoe @marlitas