Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropper does not need to be movable for alt input. #252

Closed
pixelzoom opened this issue Oct 7, 2022 · 2 comments
Closed

Dropper does not need to be movable for alt input. #252

pixelzoom opened this issue Oct 7, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 7, 2022

Related to #249 (support for alt input)...

@arouinfar and I discussed potential problems with the dropper.

Being able to move the dropper is not significant to learning goals, but (during Java version design) was kept to make the sim more "fun". That immediately caused problems with how to press the button and drag the dropper at the same time, which we did figure out how to do for mouse/touch. Figuring that out for alt input would be a big lift, and (again) is not a necessary user interaction.

Making the dropper movable also presents focus issues. Currently, the dropper gets focus, then the dropper button gets focus. That seems odd, but maybe it's OK. And it's complicated because the dopper is in common code, while the sim is responsible for making it movable. In any case, this would require a full a11y design for the dropper. That's something that we do not have time for right now, and it's moot if the dropper is not movable.

So... We decided that it's OK for the dropper to remain in a fixed location, and not be focusable. I will remove the dropper's focusability, KeyboardDragListener, and revise the keyboard help.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Oct 7, 2022

Before making changes, I published 1.6.0-dev.4 with the original alt-input behavior of the dropper, where the dropper is movable via the keyboard.

After making changes, I published 1.6.0-dev.5 with the revisions described above -- the dropper is NOT movable via the keyboard.

Reminder that the dropper's button will get focus, but the button's behavior is broken until phetsims/sun#796 is addressed.

@arouinfar please review. Reminder to review keyboard help. If this looks OK, feel free to close.

@pixelzoom pixelzoom assigned arouinfar and unassigned pixelzoom Oct 7, 2022
@pixelzoom pixelzoom changed the title Dopper does not need to be movable for alt input. Dropper does not need to be movable for alt input. Oct 7, 2022
@arouinfar
Copy link
Contributor

Thanks @pixelzoom, looks good in dev.5, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants