change requests for dropper alt input, #252

phetsims · Oct 7, 2022 · fa6378f · fa6378f
1 parent 31acdaf
commit fa6378f
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 15 deletions.
diff --git a/js/PhScaleStrings.ts b/js/PhScaleStrings.ts
@@ -56,8 +56,7 @@ type StringsType = {
     'chooseASoluteStringProperty': LinkableProperty<string>;
     'soluteStringProperty': LinkableProperty<string>;
     'solutesStringProperty': LinkableProperty<string>;
-    'moveThePHProbeOrDropperStringProperty': LinkableProperty<string>;
-    'moveTheDropperStringProperty': LinkableProperty<string>;
+    'moveThePHProbeStringProperty': LinkableProperty<string>;
     'moveTheGraphIndicatorsStringProperty': LinkableProperty<string>;
     'moveStringProperty': LinkableProperty<string>;
     'moveSlowerStringProperty': LinkableProperty<string>;

diff --git a/js/common/view/PHDropperNode.ts b/js/common/view/PHDropperNode.ts
@@ -33,8 +33,6 @@ export default class PHDropperNode extends EyeDropperNode {
         enabledProperty: dropper.enabledProperty
       },
       cursor: null,
-      tagName: 'div',
-      focusable: true,
       phetioInputEnabledPropertyInstrumented: true
     }, providedOptions );
 

diff --git a/js/macro/view/MacroKeyboardHelpContent.ts b/js/macro/view/MacroKeyboardHelpContent.ts
@@ -20,8 +20,8 @@ export default class MacroKeyboardHelpContent extends TwoColumnKeyboardHelpConte
 
     const leftColumn = [
 
-      // Move the pH Probe and Dropper
-      new MoveKeyboardHelpContent( PhScaleStrings.keyboardHelpDialog.moveThePHProbeOrDropperStringProperty ),
+      // Move the pH Probe
+      new MoveKeyboardHelpContent( PhScaleStrings.keyboardHelpDialog.moveThePHProbeStringProperty ),
 
       // Faucet Controls
       new FaucetControlsKeyboardHelpContent()

diff --git a/js/micro/view/MicroKeyboardHelpContent.ts b/js/micro/view/MicroKeyboardHelpContent.ts
@@ -8,7 +8,6 @@
 
 import TwoColumnKeyboardHelpContent from '../../../../scenery-phet/js/keyboard/help/TwoColumnKeyboardHelpContent.js';
 import phScale from '../../phScale.js';
-import MoveKeyboardHelpContent from '../../common/view/MoveKeyboardHelpContent.js';
 import PhScaleStrings from '../../PhScaleStrings.js';
 import ComboBoxKeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/ComboBoxKeyboardHelpSection.js';
 import BasicActionsKeyboardHelpSection from '../../../../scenery-phet/js/keyboard/help/BasicActionsKeyboardHelpSection.js';
@@ -20,9 +19,6 @@ export default class MicroKeyboardHelpContent extends TwoColumnKeyboardHelpConte
 
     const leftColumn = [
 
-      // Move the Dropper
-      new MoveKeyboardHelpContent( PhScaleStrings.keyboardHelpDialog.moveTheDropperStringProperty ),
-
       // Faucet Controls
       new FaucetControlsKeyboardHelpContent()
     ];

diff --git a/ph-scale-strings_en.json b/ph-scale-strings_en.json
@@ -101,11 +101,8 @@
   "keyboardHelpDialog.solutes": {
     "value": "solutes"
   },
-  "keyboardHelpDialog.moveThePHProbeOrDropper": {
-    "value": "Move the pH Probe or Dropper"
-  },
-  "keyboardHelpDialog.moveTheDropper": {
-    "value": "Move the Dropper"
+  "keyboardHelpDialog.moveThePHProbe": {
+    "value": "Move the pH Probe"
   },
   "keyboardHelpDialog.moveTheGraphIndicators": {
     "value": "Move the Graph Indicators"