Updates to BasicActionsKeyboardHelpSection keyboard section for basic alt-input

[zepumph]

From alt input meeting today, and from #86.

@Matthew-Moore240 will take a first pass on it.

[zepumph]

An idea from the meeting. Add 2 more items to the "basic actions" section:

1. 2d dragging. "Navigate to the draggable and move the arrow keys to drag me!"
2. Keypad interaction "Type numbers, backspace, decimal, minus to use the keypad".

Please provide for each row:

1. visual look of the row
2. described pdom content
3. placement of the row in the section.

[zepumph]

patch to add basic section to MSS:

Subject: [PATCH] translatable strings for hot key help content, https://github.com/phetsims/scenery-phet/issues/797
---
Index: js/lab/LabScreen.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/lab/LabScreen.ts b/js/lab/LabScreen.ts
--- a/js/lab/LabScreen.ts	(revision 68f366b3d1f9550b8c58c91dd3c699fdde8a94e2)
+++ b/js/lab/LabScreen.ts	(date 1678313569678)
@@ -14,6 +14,7 @@
 import LabScreenView from './view/LabScreenView.js';
 import LabScreenIcon from './view/LabScreenIcon.js';
 import MySolarSystemStrings from '../MySolarSystemStrings.js';
+import BasicActionsKeyboardHelpSection from '../../../scenery-phet/js/keyboard/help/BasicActionsKeyboardHelpSection.js';
 
 class LabScreen extends Screen<LabModel, LabScreenView> {
 
@@ -23,7 +24,10 @@
       homeScreenIcon: new LabScreenIcon(),
       backgroundColorProperty: SolarSystemCommonColors.backgroundProperty,
       tandem: tandem,
-      name: MySolarSystemStrings.screen.labStringProperty
+      name: MySolarSystemStrings.screen.labStringProperty,
+      createKeyboardHelpNode: () => {
+        return new BasicActionsKeyboardHelpSection( { withCheckboxContent: true } );
+      }
     };
 
     super(
Index: js/intro/IntroScreen.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/intro/IntroScreen.ts b/js/intro/IntroScreen.ts
--- a/js/intro/IntroScreen.ts	(revision 68f366b3d1f9550b8c58c91dd3c699fdde8a94e2)
+++ b/js/intro/IntroScreen.ts	(date 1678313433728)
@@ -14,6 +14,7 @@
 import IntroScreenView from './view/IntroScreenView.js';
 import IntroScreenIcon from './view/IntroScreenIcon.js';
 import MySolarSystemStrings from '../MySolarSystemStrings.js';
+import BasicActionsKeyboardHelpSection from '../../../scenery-phet/js/keyboard/help/BasicActionsKeyboardHelpSection.js';
 
 class IntroScreen extends Screen<IntroModel, IntroScreenView> {
 
@@ -23,7 +24,10 @@
       homeScreenIcon: new IntroScreenIcon(),
       backgroundColorProperty: SolarSystemCommonColors.backgroundProperty,
       tandem: tandem,
-      name: MySolarSystemStrings.screen.introStringProperty
+      name: MySolarSystemStrings.screen.introStringProperty,
+      createKeyboardHelpNode: () => {
+        return new BasicActionsKeyboardHelpSection( { withCheckboxContent: true } );
+      }
     };
 
     super(

[Matthew-Moore240]

Here are the new keyboard shortcuts along with the order they are in. @zepumph

H2: Basic Actions
UL:
LI: Move to next item or group with Tab key.
LI: Move to previous item or group with Shift plus Tab key.
LI: Move between items in a group with Left and Right arrow keys or Up and Down arrow keys.
LI: Move draggable objects with Left and Right arrow keys or Up and Down arrow keys.
LI: Set values within pop-up keypad using number keys 0-9.
LI: Toggle checkboxes with Space key.
LI: Press buttons with Space key.
LI: Exit a dialog with Escape key.

[zepumph]

Set values within pop-up keypad using number keys 0-9.

• What if we got rid of the "pop-up". There are may keypads that are not popup, or at least not in the same way as a full, modal dialog.

[zepumph]

• It looks like we have lost the "reset all" row. Do you want that gone?

[zepumph]

Perhaps phetsims/scenery-phet#800 is blocking My Solar System publication. Just noting here.

[zepumph]

Alright all done here. Please respond to the above two checkboxes

[zepumph]

[samreid]

API files are now showing moveDraggableObjectsStringProperty and setValuesInKeypadStringProperty. I'll commit the updated API files and reassign to @zepumph to review.

UPDATE: This impacted phetsims/calculus-grapher#225, so I'm adding a reference to it

[Matthew-Moore240]

I am totally okay with getting rid of the "pop-up" in the help text. I am not totally sure what you mean by the second checkbox.

[zepumph]

Sorry to confuse! Your comment in #93 (comment) doesn't have a line for something already existing in the basic section:

Reset All with Alt+R

Currently that remains just above the esc to exit dialogs. Is that acceptable?

[zepumph]

pop-up removed above. If the placement of the "reset all" line is acceptable. @Matthew-Moore240 please feel free to close this issue:

[zepumph]

From review today with @arouinfar:

• We will remove the draggable part from Basic section, and instead do Create common "Move Draggable Items" section scenery-phet#801
• Add TimeControlKeyboardHelpSection
• Add SliderControlsKeyboardHelpSectionOptions

Keep on using keypad in basic section

[zepumph]

Here is what my working copy currently looks like:

(it's always a bit ironic that my picture of the PDOM is not accessible here in github). @arouinfar does that seem right to you? What order are you imagining?

[zepumph]

Commits pushed

[arouinfar]

@zepumph the keyboard help dialog looks so good, thank you! Section order and PDOM content also look reasonable to me, so I think we're good to close.