Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common MoveDraggableItemsKeyboardHelpSection #451

Closed
zepumph opened this issue Mar 17, 2023 · 3 comments
Closed

Use common MoveDraggableItemsKeyboardHelpSection #451

zepumph opened this issue Mar 17, 2023 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Mar 17, 2023

Today over in phetsims/my-solar-system#93 and phetsims/scenery-phet#801, we created and are using a common help section based on the one from Geometric Optics for dragging:

image

Because this sim has been published, there is going to be some annoyance about translations for the previously GO-specific strings, but it would be best if we used the common code type in this sim.

For next time we are working on this sim!

@pixelzoom
Copy link
Contributor

Self-assigning, to consider for the 1.3 release #443.

@pixelzoom
Copy link
Contributor

scenery-phet's MoveDraggableItemsKeyboardHelpSection is now used in keyboard help. I verified that it's identical to what it replaced.

Closing.

pixelzoom added a commit that referenced this issue Apr 27, 2023
@pixelzoom
Copy link
Contributor

@zepumph said above:

Because this sim has been published, there is going to be some annoyance about translations for the previously GO-specific strings, but it would be best if we used the common code type in this sim.

In the above commit, I removed unused strings. Translators will need to translate the scenery-phet strings used by MoveDraggableItemsKeyboardHelpSection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants