Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should cueing arrows disappear when item isn't interactive? #322

Closed
KatieWoe opened this issue Jul 10, 2024 · 6 comments
Closed

Should cueing arrows disappear when item isn't interactive? #322

KatieWoe opened this issue Jul 10, 2024 · 6 comments
Assignees
Labels
type:bug Something isn't working

Comments

@KatieWoe
Copy link

Device
Samsung
OS
Win 11
Browser
Firefox
Problem Description
For phetsims/qa#1105
In studio, if you remove interactivity with the fulcrum slider (meanShareAndBalance.balancePointScreen.view.notepadNode.balanceBeamNode.meanPredictionFulcrumSlider.enabledProperty) the cueing arrow still appears, even though you can't drag the object anymore.
Visuals
enablearrows

@KatieWoe KatieWoe added the type:bug Something isn't working label Jul 10, 2024
@amanda-phet
Copy link
Contributor

I think we discussed instrumenting the cue, but I don't remember what came out of the discussion. Is this something we can instrument @marlitas ? Or should I put something in examples.md about how to turn it off? (basically if you interact with it to remove it, the lack of cue arrow seems to be saved to the state)

@marlitas
Copy link
Contributor

@amanda-phet my understanding is that we shouldn't instrument keyboard and mouse cues so that users can still get the cues if the item was interacted with before the wrapper was created. This is also how our cues are working for soccer balls and candy bars. I will tie the visibility of the mouse cues to the enabled property of the fulcrum. I think that will fix the underlying problem here.

@marlitas
Copy link
Contributor

The cueing arrows will now disappear if the slider has been disabled. @amanda-phet let me know if that works for you.

image

@amanda-phet
Copy link
Contributor

Reviewed with @marlitas and she also added some documentation to meanPredictionFulcrumSlider so I think this is all looking good!

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Aug 1, 2024

I also see this with the soccer balls but may be related to #337
Screenshot 2024-08-01 at 2 01 49 PM

Tagging phetsims/qa#1121

@marlitas
Copy link
Contributor

marlitas commented Aug 2, 2024

This question is being handled in #337 since it is a special use case. Closing.

@marlitas marlitas closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants