-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested changes to examples.md #317
Comments
This one is for @marlitas: Please feature: EDIT: here's one more: They are currently listed in the examples.md, but not featured. |
Thanks @Nancy-Salpepi ! I think all of those things look good now, if you want to take a peek (looking at the commit will make it easy to see the changes). @marlitas can you please feature these elements:
|
This is ready for review by @amanda-phet and @Nancy-Salpepi |
Thanks @marlitas those look good to me. @Nancy-Salpepi please feel free to close after you've reviewed examples.md to be sure it looks clear to you. |
@amanda-phet just wanted to note that this can also be done by direct interaction with the sim (using the number spinner):
Also, would an instructor still want students to be able to use the decrement button afterwards? This would make the Kick button reappear. Not sure what the learning goal is. |
Everything else looks good on main. |
I added that extra note about how to kick the balls. I don't think we need to go into hiding the number spinner. Nodes have a visibleProperty, but the kick button does not because its visibility is controlled by the last ball being kicked, so that's why it has special instructions. Thanks for your review! |
For phetsims/qa#1105, in the examples.md the current directions for hiding the kick button are incorrect (or I am interpreting them incorrectly).
This is what I did:
If you flip the 2 steps, then the Kick Button won't be there.
The text was updated successfully, but these errors were encountered: