Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes to examples.md #317

Closed
Nancy-Salpepi opened this issue Jul 9, 2024 · 9 comments
Closed

Suggested changes to examples.md #317

Nancy-Salpepi opened this issue Jul 9, 2024 · 9 comments

Comments

@Nancy-Salpepi
Copy link

For phetsims/qa#1105, in the examples.md the current directions for hiding the kick button are incorrect (or I am interpreting them incorrectly).

Screenshot 2024-07-09 at 2 24 41 PM

This is what I did:

  1. Kicked 3 balls
  2. Set Max Property to 3 --> the kicked balls disappear and the Kick button is still present.

If you flip the 2 steps, then the Kick Button won't be there.

@Nancy-Salpepi Nancy-Salpepi changed the title Directions to hide the Kick button are unclear Directions for 'Hide the Kick button' are unclear Jul 9, 2024
@Nancy-Salpepi Nancy-Salpepi changed the title Directions for 'Hide the Kick button' are unclear Suggested changes to examples.md Jul 9, 2024
@Nancy-Salpepi
Copy link
Author

For this section I think it would be helpful to first have a step about setting the predictMeanVisibleProperty to True before setting its location and hiding the pencil:
Screenshot 2024-07-09 at 2 29 24 PM

@Nancy-Salpepi
Copy link
Author

Nancy-Salpepi commented Jul 9, 2024

This one is for @marlitas:

Please feature:
meanShareAndBalance.distributeScreen.model.meanPredictionProperty
meanShareAndBalance.distributeScreen.view.meanPredictionLine.meanPredictionHandle.visibleProperty

EDIT: here's one more:
meanShareAndBalance.balancePointScreen.model.sceneModel.kickDistributionStrategy

They are currently listed in the examples.md, but not featured.

@Nancy-Salpepi
Copy link
Author

In the section "Determine if the notepad is displaying the mean" for the Balance Point Screen, change meanPropertyValue to meanValueProperty

Screenshot 2024-07-09 at 4 51 34 PM Screenshot 2024-07-09 at 4 57 41 PM

@amanda-phet
Copy link
Contributor

Thanks @Nancy-Salpepi ! I think all of those things look good now, if you want to take a peek (looking at the commit will make it easy to see the changes).

@marlitas can you please feature these elements:

  • meanShareAndBalance.distributeScreen.model.meanPredictionProperty
  • meanShareAndBalance.distributeScreen.view.meanPredictionLine.meanPredictionHandle.visibleProperty
  • meanShareAndBalance.balancePointScreen.model.sceneModel.kickDistributionStrategy

@marlitas
Copy link
Contributor

This is ready for review by @amanda-phet and @Nancy-Salpepi

@amanda-phet
Copy link
Contributor

Thanks @marlitas those look good to me.

@Nancy-Salpepi please feel free to close after you've reviewed examples.md to be sure it looks clear to you.

@amanda-phet amanda-phet removed their assignment Jul 17, 2024
@Nancy-Salpepi
Copy link
Author

@amanda-phet just wanted to note that this can also be done by direct interaction with the sim (using the number spinner):

Hide the Kick button
The visibilily of the Kick button is determined by whether there are any balls available to be kicked. The button can be hidden using maxKicksProperty: first set maxKicksProperty to the desired number, then kick all balls onto the field.
meanShareAndBalance.balancePointScreen.model.maxKicksProperty

Also, would an instructor still want students to be able to use the decrement button afterwards? This would make the Kick button reappear. Not sure what the learning goal is.

@Nancy-Salpepi
Copy link
Author

Everything else looks good on main.

@amanda-phet
Copy link
Contributor

I added that extra note about how to kick the balls. I don't think we need to go into hiding the number spinner. Nodes have a visibleProperty, but the kick button does not because its visibility is controlled by the last ball being kicked, so that's why it has special instructions. Thanks for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants