Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large time goes off the edge of the stopwatch #323

Closed
KatieWoe opened this issue Nov 26, 2024 · 4 comments
Closed

Large time goes off the edge of the stopwatch #323

KatieWoe opened this issue Nov 26, 2024 · 4 comments

Comments

@KatieWoe
Copy link
Contributor

Test device
Samsung
Operating System
Win 11
Browser
Chrome
Problem description
For phetsims/qa#1179
If the stop watch records for over 100 minutes, the time will go off the edge of the stopwatch. Reproducing this takes less time if you use ?speed=10.

Visuals
longnumberswatch

Troubleshooting information:

!!!!! DO NOT EDIT !!!!!
Name: ‪Forces and Motion: Basics‬
URL: https://phet-dev.colorado.edu/html/forces-and-motion-basics/2.4.0-dev.7/phet/forces-and-motion-basics_all_phet.html?speed=10
Version: 2.4.0-dev.7 2024-11-26 17:47:57 UTC
Features missing: applicationcache, applicationcache, touch
Flags: pixelRatioScaling
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
Language: en-US
Window: 1536x695
Pixel Ratio: 1.25/1
WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium)
GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium)
Vendor: WebKit (WebKit WebGL)
Vertex: attribs: 16 varying: 30 uniform: 4096
Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32)
Max viewport: 32767x32767
OES_texture_float: true
Dependencies JSON: {}

@KatieWoe
Copy link
Contributor Author

Linking to #288

@arouinfar
Copy link

If I'm not mistaken, StopwatchNode should have an option for a max time. In this context 59:59.99 seems appropriate. There is no need for the stopwatch to run longer than 1 hour.

@marlitas
Copy link
Contributor

marlitas commented Dec 2, 2024

I set the max range as requested above and this should now be addressed on main. Over to @KatieWoe to review and close if all looks well.

@KatieWoe
Copy link
Contributor Author

KatieWoe commented Dec 2, 2024

Looks good on main

@KatieWoe KatieWoe closed this as completed Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants