-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User request: Add stop watch #288
Comments
This is an interesting suggestion. We should consider it the next time this sim is resisting. Unassinging myself for now. |
Tagging for design meeting to discuss if we want to address this with #304 |
Addressed in the above commit. Please keep in mind that neither the Stopwatch (element in the model that keeps track of time), nor the StopwatchNode (node in the view which displays the tool) have tandem on them. The checkbox on the other hand did get a tandem, since the constructor was clear enough for me to infer the appropriate tree structure. If you need PhET-iO for this feature, please let me know the specs. Otherwise, please review and close if OK. |
The stopwatch looks good to me. @arouinfar or @kathy-phet any thoughts about the phet-io question? |
The stopwatch also looks good to me. The PhET-iO instrumentation of this sim predates Hydrogen and our modern design processes. It will be a significant effort to republish this simulation with PhET-iO, and we're only including phet-brand in the upcoming release, so I think we can defer instrumenting the Stopwatch until later. The Stopwatch should be tested during the QA process, so assigning back to @AgustinVallejo to make sure this is on the list of issues for QA during dev testing. |
As the region and culture publication won't include PhET-iO, keeping this as ready for review by QA during dev testing and unassigning @AgustinVallejo and @kathy-phet. |
The stopwatch has been added to the Motion and Friction Screens. |
@Nancy-Salpepi I don't see the stop watch in the published sim? Is this in an upcoming version (2.4.0)? Also, please keep "user requests/suggestion" tickets open and assign to me so that I can alert the requesting user. Thanks! |
Sorry @oliver-phet! It is in dev test right now. |
Assigning to @arouinfar for evaluation.
The text was updated successfully, but these errors were encountered: