Improve getPoints() + explode() performance for large geometries #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
For geometries with 10k+ points, it can take 10+ seconds on a modern machine to call
getPoints()
orpointInPolygon()
.Root Cause
The points array was built using
array_merge()
, which gets more complex (n^2) as the array gets larger.Fix
Use simple array appending instead of
array_merge()
Before:
After: