Improve getPoints() + explode() performance for large geometries (mer…

…ges PR phayes#127)
itamair · Feb 4, 2023 · c1a7af6 · c1a7af6
1 parent 84803f6
commit c1a7af6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/geometry/Collection.class.php b/lib/geometry/Collection.class.php
@@ -231,7 +231,9 @@ public function numPoints() {
   public function getPoints() {
     $points = array();
     foreach ($this->components as $component) {
-      $points = array_merge($points, $component->getPoints());
+      foreach ($component->getPoints() as $point) {
+        $points[] = $point;
+      }
     }
     return $points;
   }
@@ -290,7 +292,9 @@ public function isSimple() {
   public function explode() {
     $parts = array();
     foreach ($this->components as $component) {
-      $parts = array_merge($parts, $component->explode());
+      foreach ($component->explode() as $subComponent) {
+        $parts[] = $subComponent;
+      }
     }
     return $parts;
   }