Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New Finder log errors to Transcript setting #661

Merged
merged 1 commit into from
Jan 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/NewTools-Finder-Tests/StFinderExampleTest.class.st
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Class {
#name : 'StFinderExampleTest',
#superclass : 'StFinderTest',
#instVars : [
'previousLogSetting'
],
#category : 'NewTools-Finder-Tests-Core',
#package : 'NewTools-Finder-Tests',
#tag : 'Core'
Expand All @@ -10,11 +13,23 @@ Class {
StFinderExampleTest >> setUp [

super setUp.

"Avoid polluting the CI output during tests"
previousLogSetting := StFinderSettings logErrorsToTranscript.
StFinderSettings logErrorsToTranscript: false.

presenterModel currentSearch: StFinderExampleSearch new.
self openInstance.

]

{ #category : 'running' }
StFinderExampleTest >> tearDown [

StFinderSettings logErrorsToTranscript: previousLogSetting.
super tearDown.
]

{ #category : 'running' }
StFinderExampleTest >> testConcatenationSearch [

Expand Down
4 changes: 2 additions & 2 deletions src/NewTools-Finder/StFinderSettings.class.st
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ StFinderSettings class >> logErrorsToTranscript [
"Modified by settings Finder: self classSide >> #logErrorsToTranscriptOn:"

^ LogErrorsToTranscript
ifNil: [ LogErrorsToTranscript := true ]
ifNil: [ LogErrorsToTranscript := false ]
]

{ #category : 'system settings' }
Expand All @@ -158,7 +158,7 @@ StFinderSettings class >> logErrorsToTranscriptOn: aBuilder [
<systemsettings>
(aBuilder setting: #logErrorsToTranscript)
parent: #finder;
default: true;
default: false;
label: 'Log errors to Transcript';
description: 'Log evaluation errors in the examples search to the Transcript';
target: self
Expand Down
Loading