Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update New Finder log errors to Transcript setting #661

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Update New Finder log errors to Transcript setting #661

merged 1 commit into from
Jan 21, 2024

Conversation

hernanmd
Copy link
Member

This PR changes the default in logErrorsToTranscript setting, so we do not pollute output by default.
Also execute the Example tests without logging to transcript so the CI isn't polluted.

Change default in logErrorsToTranscript setting, so we do not pollute…
1e9615f 
… output by default.

Also execute the Example tests without logging to transcript so the CI isn't polluted.
@hernanmd hernanmd self-assigned this Jan 21, 2024
@hernanmd hernanmd added the enhancement New feature or request label Jan 21, 2024
@hernanmd hernanmd mentioned this pull request Jan 21, 2024
Closed
@Ducasse
Copy link
Contributor

Ducasse commented Jan 21, 2024

Hi hernan
why do we expect to have messageNotUnderstand in the finder (no need to reply now you can explain it to me next time we meet).

@Ducasse Ducasse merged commit f36c27b into pharo-spec:Pharo12 Jan 21, 2024
1 of 2 checks passed
@hernanmd hernanmd deleted the fix_finder_testing_log branch July 6, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hernanmd hernanmd

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernanmd @Ducasse