Add #getTemporaryDirectory to UnixPlatform and WinPlatform

src/FileSystem-Core/UnixResolver.class.st

@@ -48,7 +48,9 @@ UnixResolver >> preferences [
 
 { #category : #origins }
 UnixResolver >> temp [
-	^ '/tmp' asFileReference
+
+^self directoryFromEnvVariableNamed: 'TMPDIR' or: [  
+	 '/tmp' asFileReference]
 ]
 
 { #category : #origins }

src/FileSystem-Core/WindowsResolver.class.st

@@ -32,5 +32,6 @@ WindowsResolver >> preferences [
 
 { #category : #origins }
 WindowsResolver >> temp [
-	^ self directoryFromEnvVariableNamed: 'TEMP' or: [ FileLocator C / 'windows' / 'temp' ]
+
+	^ self resolveString: Smalltalk os getTempPath
 ]

src/FileSystem-Tests-Core/UnixResolverTest.class.st

@@ -13,6 +13,20 @@ UnixResolverTest >> createResolver [
 	^ UnixResolver new
 ]
 
+{ #category : #running }
+UnixResolverTest >> testGetTempFromTMPDIR [
+
+	| expected |
+	OSPlatform current isUnix ifFalse: [ ^ self skip ].
+
+	expected := '/tmp/foo'.
+	OSEnvironment current setEnv: 'TMPDIR' value: expected during: [ 
+		| actual |
+		actual := self createResolver temp.
+		self assert: actual fullName equals: expected ]
+
+]
+
 { #category : #tests }
 UnixResolverTest >> testXdgParseUserDirLineDocuments [
 	"Ensure that a path of the form '$HOME/Documents' answers the expected value.

src/FileSystem-Tests-Core/WindowsResolverTest.class.st

@@ -0,0 +1,22 @@
+"
+A WindowsResolverTest is a test class for testing the behavior of WindowsResolver
+"
+Class {
+	#name : #WindowsResolverTest,
+	#superclass : #TestCase,
+	#category : #'FileSystem-Tests-Core-Resolver'
+}
+
+{ #category : #tests }
+WindowsResolverTest >> testResolveTempPathFromTMP [
+
+	| expected |
+	OSPlatform current isWindows ifFalse: [ ^ self skip ].
+
+	expected := 'X:\Temp'.
+
+	OSEnvironment current setEnv: 'TMP' value: expected during: [
+		| actual |
+		actual := WindowsResolver new temp.
+		self assert: actual fullName equals: expected ]
+]

src/System-OSEnvironments-Tests/OSEnvironmentTest.class.st

@@ -7,11 +7,24 @@ Class {
 	#category : #'System-OSEnvironments-Tests'
 }
 
+{ #category : #helper }
+OSEnvironmentTest >> envNameForTest [
+
+	^ 'PHAROTEST'
+]
+
 { #category : #helper }
 OSEnvironmentTest >> instance [
 	^ Smalltalk os environment
 ]
 
+{ #category : #running }
+OSEnvironmentTest >> tearDown [
+
+	self instance removeKey: self envNameForTest.
+	super tearDown
+]
+
 { #category : #tests }
 OSEnvironmentTest >> testAsDictionary [
 	self assert: self instance asDictionary isDictionary
@@ -75,6 +88,40 @@ OSEnvironmentTest >> testKeys [
 	self assert: (env includesKey: keys anyOne)
 ]
 
+{ #category : #tests }
+OSEnvironmentTest >> testSettingEnvValueDuringChangesValueInDuringBlock [
+
+	| envName expected |
+	envName := self envNameForTest.
+	self instance setEnv: envName value: 'Before'.
+	expected := 'After'.
+	self instance setEnv: envName value: expected during: [
+		| actual |
+		actual := self instance at: envName.
+		self assert: actual equals: expected ]
+]
+
+{ #category : #tests }
+OSEnvironmentTest >> testSettingEnvValueDuringRevertsValueAfterDuringBlock [
+
+	| actual envName expected |
+	envName := self envNameForTest.
+	self instance setEnv: envName value: 'Before'.
+	expected := 'After'.
+	self instance setEnv: envName value: expected during: [  ].
+	actual := self instance at: envName.
+	self assert: actual equals: expected
+]
+
+{ #category : #tests }
+OSEnvironmentTest >> testSettingNewEnvValueDuringRemovesItAfterDuringBlock [
+
+	| envName |
+	envName := self envNameForTest.
+	self instance setEnv: envName value: 'During' during: [  ].
+	self deny: (self instance includesKey: envName)
+]
+
 { #category : #tests }
 OSEnvironmentTest >> testValues [
 	| env values |

src/System-OSEnvironments/OSEnvironment.class.st

@@ -250,6 +250,19 @@ OSEnvironment >> setEnv: nameString value: valueString [
 	^ self subclassResponsibility
 ]
 
+{ #category : #accessing }
+OSEnvironment >> setEnv: nameString value: valueString during: aBlock [
+
+	| oldValue |
+	oldValue := self at: nameString ifAbsent: [ nil ].
+	[
+	self setEnv: nameString value: valueString.
+	aBlock value ] ensure: [
+		oldValue
+			ifNil: [ self removeKey: nameString ]
+			ifNotNil: [ self setEnv: nameString value: valueString ] ]
+]
+
 { #category : #accessing }
 OSEnvironment >> unsetEnv: string [
 	"This method calls the the platform specific unset environment routine"

src/System-Platforms-Tests/Win32EnvironmentTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #Win32EnvironmentTest,
 	#superclass : #TestCase,
-	#category : #'System-Platforms-Tests-Win32'
+	#category : #'System-Platforms-Tests-Windows'
 }
 
 { #category : #tests }

src/System-Platforms-Tests/Win32WideStringTest.class.st

@@ -1,7 +1,7 @@
 Class {
 	#name : #Win32WideStringTest,
 	#superclass : #TestCase,
-	#category : #'System-Platforms-Tests-Win32'
+	#category : #'System-Platforms-Tests-Windows'
 }
 
 { #category : #tests }

src/System-Platforms-Tests/WinPlatformTest.class.st

@@ -0,0 +1,21 @@
+Class {
+	#name : #WinPlatformTest,
+	#superclass : #TestCase,
+	#category : #'System-Platforms-Tests-Windows'
+}
+
+{ #category : #tests }
+WinPlatformTest >> testGetTempPathFromTMP [
+
+	| value |
+	OSPlatform current isWindows ifFalse: [ ^ self skip ].
+
+	value := OSEnvironment current at: 'TMP' ifAbsent: [ nil ].
+	[
+	| actual expected |
+	expected := 'X:\Temp\'.
+	OSEnvironment current at: 'TMP' put: expected.
+	actual := OSPlatform current getTempPath.
+	self assert: actual equals: expected ] ensure: [
+		value ifNotNil: [ OSEnvironment current at: 'TMP' put: value ] ]
+]

src/System-Platforms/WinPlatform.class.st

@@ -71,6 +71,23 @@ WinPlatform >> getErrorMessage: anInteger [
     ^ buffer asString
 ]
 
+{ #category : #'file paths' }
+WinPlatform >> getTempPath [
+
+  | buffer length |
+	length := self defaultMaximumPathLength.
+	buffer := (String new: length) asWin32WideString.
+	self getTempPath: length buffer: buffer.
+	^buffer asString
+]
+
+{ #category : #'file paths' }
+WinPlatform >> getTempPath: bufferLength buffer: buffer [
+
+    self ffiCall: #(long GetTempPath2W(long bufferLength,
+                            void*  buffer))
+]
+
 { #category : #testing }
 WinPlatform >> isWindows [
 	^ true