-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #getTemporaryDirectory to UnixPlatform and WinPlatform #13777
Conversation
…ted tests. Do not add yet an abstract #getTemporaryDirectory to OSPlatform as macOS might require additional work to support NSTemporaryDirectory.
I am wondering what is the use of those new methods? We already have |
@jecisc I was not aware of FileLocator temp Looking at the underlying behaviour it doesn’t appear to be correct - e.g. for Windows the TMP env variable should have precedence over TEMP. |
Thank you! :) |
Update UnixResolver>>temp to follow the POSIX 2007 spec
The tests passed and now it improves the current implementation so it's way better! The code seems good but I'm not an expert on this part of the system so another review might be nice |
The output of the Windows test running step in build 3 of pull request #16337 shows the implementation of
This might be due to the Jenkins agent not meeting the requirements for ‘GetTempPath2W’ (‘Windows 10 Build 20348’ / ‘Windows Server Build 20348’). @gcorriga: Could ‘GetTempPathW’ be used instead? |
@Rinzwind I believe it should be possible to use GetTempPathW. No issues from me if you want to go ahead with this change. Please note, I am on paternity break until April 2nd so I won't be able to help much. |
OK, I have opened a pull request to change it: pull request #16342. |
Add #getTemporaryDirectory to UnixPlatform and WinPlatform, with related tests.
Do not add yet an abstract #getTemporaryDirectory to OSPlatform as macOS might require additional work to support NSTemporaryDirectory.