Clean MCMethodDefinitionTest #13376
Merged
Clean MCMethodDefinitionTest #13376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is one of the many steps needed to fix #13349.
MCMethodDefinitionTest is not really nice and leaves the system in a dirty states.
First it generates a package that it does not remove.
Second it recompiles its own code
Third it updates the Monticello mock package present in the image
This is an cleaning so that every code compilation happening is done in generated packages that get cleaned so that we do not dirty the code commited to Pharo.