Execute Release-Tests last on CI #13349
Open
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a lot of tests in Pharo and it might happen that some of them do not respect the principle of letting the system clean with their tearDown. To help to spot those impacts, I propose to run the releases tests last. Like this, if some bad generated code/or modifications of system entities happens, we might catch it with the verifications of release tests. I expect this commit to break the tests in the CI but it'll help me find the culprits and fix them.
|
Nice. Since tests force the coverage (of) some code, thus performs code transformation because of deprecation, is there a release test that check that the code is pristine/unmodified? |
|
There is none yet, but I would love to have that :) |
|
But we will need some work to get it because in Pharo 12 it comes with dirty packages, so this test would fail currently |
privat
approved these changes
Apr 7, 2023
|
More than 10 tests failures because the tests are dirtying the image D: |
jecisc
added
the
Status: Need more work
|
Here is a first fix: pharo-spec/NewTools#504 |
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Apr 9, 2023
ClassRenameFixTest is way too complicated for what it does. This aim to simplify it and make it cleaner. Currently running this test was leaving the system in a dirty state leaving an empty package. (cf. pharo-project#13349) Now, instead of saving all the changes and trying to revert it, the code generated is all in a specific package that we remove in the tear down. I removed a double initialization. And finally I inlined #renameClassUsing: because this method was doing almost everything and the test nothing
This was referenced Apr 9, 2023
This was referenced Nov 7, 2023
jecisc
added
Status: Need more work
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a lot of tests in Pharo and it might happen that some of them do not respect the principle of letting the system clean with their tearDown. To help to spot those impacts, I propose to run the releases tests last. Like this, if some bad generated code/or modifications of system entities happens, we might catch it with the verifications of release tests.
I expect this commit to break the tests in the CI but it'll help me find the culprits and fix them.