Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest stable Zephir #14191

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Use latest stable Zephir #14191

merged 1 commit into from
Jun 20, 2019

Conversation

sergeyklay
Copy link
Contributor

@sergeyklay sergeyklay commented Jun 20, 2019

Hello!

  • Type: feature | code quality
  • Link to issue: -

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

  • Update Zephir & Zephir Parser
  • Minor provision cleaning up

Thanks

@sergeyklay sergeyklay force-pushed the feature/use-latest-stable-zephir branch from 18f3bfb to 47977ce Compare June 20, 2019 14:43
@sergeyklay sergeyklay self-assigned this Jun 20, 2019
@codecov
Copy link

codecov bot commented Jun 20, 2019

Codecov Report

Merging #14191 into 4.0.x will decrease coverage by 8.69%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14191      +/-   ##
==========================================
- Coverage   74.73%   66.03%    -8.7%     
==========================================
  Files         454      455       +1     
  Lines       94193   110965   +16772     
==========================================
+ Hits        70396    73277    +2881     
- Misses      23797    37688   +13891
Impacted Files Coverage Δ
ext/phalcon/loader.zep.c 51.51% <0%> (-36.52%) ⬇️
ext/phalcon/validation/validator/uniqueness.zep.c 39.2% <0%> (-32.3%) ⬇️
ext/phalcon/config/adapter/grouped.zep.c 64.46% <0%> (-31.19%) ⬇️
ext/phalcon/db/adapter/pdo/mysql.zep.c 55.24% <0%> (-28.17%) ⬇️
ext/phalcon/db/adapter/pdo/sqlite.zep.c 55.62% <0%> (-26.18%) ⬇️
...lcon/mvc/model/metadata/strategy/annotations.zep.c 53.57% <0%> (-25.98%) ⬇️
ext/phalcon/acl/adapter/memory.zep.c 69.52% <0%> (-23%) ⬇️
...t/phalcon/logger/formatter/abstractformatter.zep.c 70.49% <0%> (-22.54%) ⬇️
ext/phalcon/cli/router.zep.c 60.98% <0%> (-22.27%) ⬇️
...lcon/translate/interpolator/associativearray.zep.c 61.9% <0%> (-21.43%) ⬇️
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cacb317...47977ce. Read the comment docs.

@niden niden merged commit 1422653 into 4.0.x Jun 20, 2019
@niden niden added the enhancement Enhancement to the framework label Jun 20, 2019
@sergeyklay sergeyklay deleted the feature/use-latest-stable-zephir branch June 20, 2019 15:19
@niden niden added the 4.0 label Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants