Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sasl authentication #14120

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Added sasl authentication #14120

merged 1 commit into from
Jun 20, 2019

Conversation

niden
Copy link
Member

@niden niden commented May 23, 2019

Hello!

Type: new feature
Link to issue: #13394

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Added SASL Auth support for Libmemecached

Thanks

@niden
Copy link
Member Author

niden commented May 23, 2019

@sergeyklay > @niden The new memcached extension doesn't work on Windows because libmemcached doesn't work on Windows. Please do not merge this until I figure out how to fix AppVeyor build.

@niden niden added documentation Documentation required enhancement Enhancement to the framework labels May 23, 2019
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #14120 into 4.0.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.0.x   #14120      +/-   ##
==========================================
+ Coverage   66.31%   66.32%   +<.01%     
==========================================
  Files         475      475              
  Lines      112022   112047      +25     
==========================================
+ Hits        74292    74315      +23     
- Misses      37730    37732       +2
Impacted Files Coverage Δ
ext/phalcon/storage/adapter/libmemcached.zep.c 90.93% <0%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1640e44...1dfad20. Read the comment docs.

@sergeyklay sergeyklay self-assigned this May 25, 2019
CHANGELOG-4.0.md Outdated Show resolved Hide resolved
@sergeyklay sergeyklay added the wip Work In Progress label Jun 16, 2019
@sergeyklay
Copy link
Contributor

@niden Try again after #14191

@sergeyklay sergeyklay removed their assignment Jun 20, 2019
@sergeyklay sergeyklay removed the wip Work In Progress label Jun 20, 2019
@niden niden merged commit 0a56c20 into phalcon:4.0.x Jun 20, 2019
@niden niden deleted the T13394-libmemcached-sasl branch September 12, 2019 21:45
@niden niden added the 4.0 label Dec 2, 2019
@niden niden removed the documentation Documentation required label Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants