-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding CGE-Predicted Phenotypes to staramr's Resfinder Output #167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you have so far looks awesome. Great job getting this up and working so quickly 😄
The one comment I have so far is that you are storing a copy of the CGE gene drug table within the StarAMR data. Instead of doing this, I think it would be good to directly use the file installed as part of the ResFinder database (so that switching the ResFinder database used by StarAMR will also switch the gene-drug mapping to be consistent).
Awesome. Okay, I'll look into using the installed version of the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks so much. Merging this in.
Adds CGE-predicted phenotypes to the output of staramr.
Example running with the README's tutorial data:
Example output: