Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CGE-Predicted Phenotypes for PointFinder results #170

Closed
apetkau opened this issue Mar 14, 2023 · 3 comments
Closed

Include CGE-Predicted Phenotypes for PointFinder results #170

apetkau opened this issue Mar 14, 2023 · 3 comments
Assignees

Comments

@apetkau
Copy link
Member

apetkau commented Mar 14, 2023

As a complement to #167 (which included CGE-Predicted Phenotypes for ResFinder results) it would be nice to do the same thing for the PointFinder results. For example, as shown in the Phenotype column here https://bitbucket.org/genomicepidemiology/pointfinder_db/src/master/salmonella/phenotypes.txt

@emarinier
Copy link
Member

emarinier commented Apr 17, 2023

As discussed, as far as I can tell, the phenotypes.txt files only exist in newer versions of the database (June 2022 onwards).

Since we don't use this version of the database, I will close this, as instructed. If we update our version of the database used and want to implement this later, the WIP branch is here:

  • dev/cge-pointfinder-prediction

@emarinier
Copy link
Member

https://bitbucket.org/genomicepidemiology/pointfinder_db/src/master/salmonella/resistens-overview.txt

The resistens-overview.txt files have a Resistance column that can be used for Pointfinder.

@emarinier emarinier removed the wontfix This will not be worked on label Aug 3, 2023
@emarinier emarinier reopened this Aug 3, 2023
@emarinier emarinier self-assigned this Aug 3, 2023
@apetkau apetkau moved this to In Progress in StarAMR 0.10.0 Aug 3, 2023
@apetkau apetkau moved this from In Progress to Done in StarAMR 0.10.0 Aug 9, 2023
@apetkau
Copy link
Member Author

apetkau commented Aug 10, 2023

Fixed in #190

@apetkau apetkau closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants