Added in coverage to Project Samples table and export #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les and fix javadoc.
… no QCEntries available for the sample.
This was referenced Sep 1, 2022
…irida into project-samples-table-coverage
deepsidhu85
requested changes
Sep 2, 2022
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/sample/SampleServiceImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/sample/SampleServiceImpl.java
Show resolved
Hide resolved
deepsidhu85
requested changes
Sep 6, 2022
src/main/java/ca/corefacility/bioinformatics/irida/repositories/sample/QCEntryRepository.java
Outdated
Show resolved
Hide resolved
deepsidhu85
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added coverage column to Project Samples table and Exports. Optimized query for QCEntries to reduce db calls.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted: