Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify validate sample names #1353

Merged
merged 18 commits into from
Sep 6, 2022
Merged

Unify validate sample names #1353

merged 18 commits into from
Sep 6, 2022

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Aug 10, 2022

Description of changes

Unify validate sample name into one endpoint.

Related issue

#1349

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • [ ] Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

@ksierks ksierks changed the title Unify validate sample name Unify validate sample names Aug 10, 2022
@ksierks ksierks requested a review from ericenns August 23, 2022 17:15
@ksierks ksierks added the developer Issues effecting developers of IRIDA, but that aren't user facing label Aug 23, 2022
@ksierks ksierks marked this pull request as ready for review August 24, 2022 16:05
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks great, just need to optimize the Repository method so that we can execute 1 query vs N queries.

@ksierks ksierks requested a review from ericenns September 6, 2022 13:35
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment and this is good to merge.

@ksierks ksierks requested a review from ericenns September 6, 2022 15:36
@ericenns ericenns merged commit f500c39 into development Sep 6, 2022
@ericenns ericenns deleted the unify-sample-validation branch September 6, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Issues effecting developers of IRIDA, but that aren't user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants