Hotfix/deprecated analysis states

[apetkau]

Description of changes

Fixed issue with analyses pages not displaying by adding back in DOWNLOADING and FINISHED_DOWNLOADING states.

To test this you can setup a new instance of IRIDA 21.01.4 and run an analysis pipeline. Then, you can go into the database and switch one of the analysis states in the audit tables to DOWNLOADING. For example:

1. analysis_submission_AUD before change

+----+------------------------------------+------------------+------------------------+
| id | name                               | analysis_state   | analysis_cleaned_state |
+----+------------------------------------+------------------+------------------------+
|  1 | bio_hansel_20210518_AE014613       | NEW              | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | PREPARING        | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | PREPARED         | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | SUBMITTING       | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | RUNNING          | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | FINISHED_RUNNING | NOT_CLEANED            |
+----+------------------------------------+------------------+------------------------+

2. Switch a state to DOWNLOADING

update analysis_submission_AUD set analysis_state = 'DOWNLOADING' where id = 1 and analysis_state = 'FINISHED_RUNNING';

3. analysis_submission_AUD after change

+----+------------------------------------+------------------+------------------------+
| id | name                               | analysis_state   | analysis_cleaned_state |
+----+------------------------------------+------------------+------------------------+
|  1 | bio_hansel_20210518_AE014613       | NEW              | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | PREPARING        | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | PREPARED         | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | SUBMITTING       | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | RUNNING          | NOT_CLEANED            |
|  1 | bio_hansel_20210518_AE014613       | DOWNLOADING      | NOT_CLEANED            |
+----+------------------------------------+------------------+------------------------+

4. Try to access analyes

Now, go to Analyses > My Analyses and the page should fail to load (as described in #1004 ). Applying this fix (checking out this branch and re-running IRIDA) will fix the issue and the page will load again.

Related issue

Fix for #1004

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

• CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
• Tests added (or description of how to test) for any new features.
• [ ] User documentation updated for UI or technical changes.

[tom114]

This works as described. Tested the issue with a manually edited database as suggested. Thanks.