Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Throw link error when fast5 not available #987

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

tom114
Copy link
Contributor

@tom114 tom114 commented Apr 29, 2021

Description of changes

Added an error thrown from the fast5 remote repository when the link for fast5 data isn't available. This would happen if syncing with an older version of IRIDA.

Note this is a hotfix PR and should also be merged to development.

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

@tom114 tom114 added federation Sharing data between IRIDA installations REST API IRIDA's REST API labels Apr 29, 2021
@tom114 tom114 requested a review from deepsidhu85 April 29, 2021 20:03
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@deepsidhu85 deepsidhu85 merged commit e9a9a58 into master Apr 29, 2021
@tom114 tom114 deleted the throw-link-error-when-fast5-not-available branch April 30, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
federation Sharing data between IRIDA installations REST API IRIDA's REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants