Update: Group samples count calculation should include shared groups and projects

[malchua]

What does this PR do and why?

Describe in detail what your merge request does and why.
This PR changes the sample count of a group to incorporate sample counts from it's shared groups and projects. This update will allow the samples count to properly reflect the amount of samples shown after clicking samples on the sidebar for a group.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.
General check:

1. Click on Groups in the sidebar.
2. Take note of the samples count for any group that you know has a group or project shared with it. Click on that group.
3. Click on Samples in the sidebar.
4. At the bottom of the page, there is a section saying "Display 1-20 of X items" where X is the total number of samples this group has access to. Confirm that this number equals the one noted in step 2.

Sharing a project:

1. Click on Groups in the sidebar.
2. Take note of the samples count for any group that you have access to.
3. Click on Projects in the sidebar.
4. Select a project that you own, that has not already been shared to the group in step 2.
5. Click on Members in the sidebar.
6. Select the "Invite group" button.
7. Select the group that was noted in step 2, and give it an access level of Analyst. Click "Share".
8. Repeat the general check above with the group selected in step 2. The samples count should have increase by the direct samples count** of the project we shared.

Sharing a group:

1. Click on Groups in the sidebar.
2. Take note of the samples count for any group that you have access to.
3. Select a different group that you have access to and want to share with the group in step 2. This different group should not already be shared with the group in step 2.
4. Click on Members in the sidebar.
5. Select the "Invite group" button.
6. Select the group that was noted in step 2, and give it an access level of Analyst. Click "Share".
7. Repeat the general check above with the group selected in step 2. The samples count should have increase by the direct samples count** of the group we shared.

**Direct samples count for a shared project = samples count of that project
**Direct samples count for a shared group = the sum of all samples found within projects in itself and it's ancestor groups. (This does not include the samples count of projects or groups that have been shared with it)

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the PR acceptance checklist for this PR.

[JeffreyThiessen]

Looks good and is working as specified. Just one small change.

[JeffreyThiessen]

Looks good to me 👍

[ericenns]

This is looking great, just one small comment.

Can you change line 15 in app/controllers/groups/samples_controller.rb to use aggregated_samples_count instead of the query it is currently doing.

[malchua]

This is looking great, just one small comment.

Can you change line 15 in app/controllers/groups/samples_controller.rb to use aggregated_samples_count instead of the query it is currently doing.

Changed in bcc3fed

[ericenns]

One minor comment, but also could you review and fix the rubocop warnings in app/models/group.rb

Mean't to request changes

[ericenns]

This is looking great, just only one minor comment and then this can be merged in.

[github-actions]

Code Metrics Report

Coverage	Test Execution Time
92.9%	10m20s

Code coverage of files in pull request scope (99.3%)

Files	Coverage
app/components/namespace_tree/row/row_contents_component.html.erb	100.0%
app/controllers/groups/samples_controller.rb	98.0%
app/models/group.rb	100.0%

---

Reported by octocov

[ericenns]

Looks good to me!