Refactor function to have an earlier return

phac-nml · Dec 20, 2024 · 73d2743 · 73d2743
1 parent b597634
commit 73d2743
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/models/group.rb b/app/models/group.rb
@@ -92,9 +92,9 @@ def shared_namespace_metadata_keys(namespace)
   end
 
   def aggregated_samples_count # rubocop:disable Metrics/AbcSize
-    aggregated_samples_count = samples_count
+    return samples_count unless shared_namespaces.any?
 
-    return aggregated_samples_count unless shared_namespaces.any?
+    aggregated_samples_count = samples_count
 
     projects_ids = []
     shared_groups.self_and_descendants.where(type: [Namespaces::ProjectNamespace.sti_name])