Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnComponent: Exclude non-fastq files if no fastq are present #742

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Sep 9, 2024

What does this PR do and why?

Describe in detail what your merge request does and why.

Do not display non-fastq files in the fastq select.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Create a new project (or just use an existing one)
  2. Create a new sample and upload a set of fastq files
  3. Create another new sample and upload some non-fastq files
  4. Go back to the project and open the dialog to launch a phac-nml/iridanextexample pipeline with the two new samples
  5. Only the sample with the fastq samples should have visible files (as seen in the above image).

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

This comment has been minimized.

@joshsadam joshsadam changed the title ColumnComponent: Include non-fastq files if no fastq are present ColumnComponent: Exclude non-fastq files if no fastq are present Sep 9, 2024

This comment has been minimized.

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a bug that I left a comment about

app/components/nextflow/samplesheet/column_component.rb Outdated Show resolved Hide resolved
Copy link

Code Metrics Report

Coverage Test Execution Time
93.0% 7m2s

Code coverage of files in pull request scope (95.0%)

Files Coverage
app/components/nextflow/samplesheet/column_component.rb 95.3%
app/components/nextflow/samplesheet_component.rb 94.5%

Reported by octocov

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ericenns ericenns merged commit a6aa6c5 into main Sep 11, 2024
3 checks passed
@ericenns ericenns deleted the emtpy_fastq branch September 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants