When using the --password env:FOO will now return an errors if (elast…

…ic#10936)

* When using the --password env:FOO will now return an errors if
FOO does not exist in the environment.

(cherry picked from commit be91dbf)

CHANGELOG.next.asciidoc

@@ -77,6 +77,9 @@ https://github.com/elastic/beats/compare/v6.6.0...6.x[Check the HEAD diff]
 - Add ECS-like selectors and dedotting to docker autodiscover. {issue}10757[10757] {pull}10862[10862]
 - Fix encoding of timestamps when using disk spool. {issue}10099[10099]
 - Include ip and boolean type when generating index pattern. {pull}10995[10995]
+- Fix unauthorized error when loading dashboards by adding username and password into kibana config. {issue}10513[10513] {pull}10675[10675]
+- Ensure all beat commands respect configured settings. {pull}10721[10721]
+- Using an environment variable for the password when enrolling a beat will now raise an error if the variable doesn't exist. {pull}10936[10936]
 
 *Auditbeat*
 

libbeat/common/cli/password.go

@@ -72,8 +72,13 @@ func stdin(p string) (string, error) {
 
 func env(p string) (string, error) {
 	if len(p) == 0 {
-		return "", errors.New("env variable name is needed when using env: password method")
+		return "", errors.New("environment variable name is needed when using env: password method")
 	}
 
-	return os.Getenv(p), nil
+	v, ok := os.LookupEnv(p)
+	if !ok {
+		return "", fmt.Errorf("environment variable %s does not exist", p)
+	}
+
+	return v, nil
 }

libbeat/common/cli/password_test.go

@@ -48,6 +48,11 @@ func TestReadPassword(t *testing.T) {
 			input: "",
 			error: true,
 		},
+		{
+			name:  "Test env variable that does not exist",
+			input: "env:DO_NOT_EXIST",
+			error: true,
+		},
 	}
 
 	for _, test := range tests {