Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using the --password env:FOO will now return an errors if #10936

Merged
merged 6 commits into from
Feb 27, 2019
Merged

When using the --password env:FOO will now return an errors if #10936

merged 6 commits into from
Feb 27, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Feb 25, 2019

FOO does not exist in the environment.

@ph ph requested a review from a team as a code owner February 25, 2019 15:45
andrewkroh
andrewkroh approved these changes Feb 25, 2019
View reviewed changes
libbeat/common/cli/password.go Outdated Show resolved Hide resolved
@ph
Copy link
Contributor Author

ph commented Feb 27, 2019

jenkins test this please

@ph
Copy link
Contributor Author

ph commented Feb 27, 2019

metricbeat error is not related.

@ph ph merged commit be91dbf into elastic:master Feb 27, 2019
@ph ph added the needs_backport PR is waiting to be backported to other branches. label Mar 8, 2019
ph added a commit to ph/beats that referenced this pull request Mar 8, 2019
@ph
When using the --password env:FOO will now return an errors if (elast…
05f87d8 
…ic#10936)

* When using the --password env:FOO will now return an errors if
FOO does not exist in the environment.

(cherry picked from commit be91dbf)
@ph ph mentioned this pull request Mar 8, 2019
Merged
@ph ph added v6.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 8, 2019
ph added a commit to ph/beats that referenced this pull request Mar 8, 2019
@ph
When using the --password env:FOO will now return an errors if (elast…
6385634 
…ic#10936)

* When using the --password env:FOO will now return an errors if
FOO does not exist in the environment.

(cherry picked from commit be91dbf)
@ph ph mentioned this pull request Mar 8, 2019
Merged
@ph ph added the v7.0.0 label Mar 8, 2019
ph added a commit that referenced this pull request Mar 8, 2019
@ph
Cherry-pick #10936 to 6.7: When using the --password env:FOO will now…
4396e28 
… return an errors if (#11159)

Cherry-pick of PR #10936 to 6.7 branch. Original message: 

FOO does not exist in the environment.
ph added a commit that referenced this pull request Mar 8, 2019
@ph
Cherry-pick #10936 to 7.0: When using the --password env:FOO will now…
8f18f78 
… return an errors if (#11160)

Cherry-pick of PR #10936 to 7.0 branch. Original message: 

FOO does not exist in the environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
Management review v6.7.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ph @andrewkroh