Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#[pg_guard] cleanup #526

Merged
merged 8 commits into from
Apr 18, 2022
Merged

#[pg_guard] cleanup #526

merged 8 commits into from
Apr 18, 2022

Commits on Apr 2, 2022

  1. Centralize the code #[pg_guard] generates.

    Add a new function to pgx-pg-sys, `create::submodules::postgres_function_guard()` and teach the `#[pg_guard]` macro to use that function instead of duplicating all the sigsetjmp code for every function.
    eeeebbbbrrrr committed Apr 2, 2022
    Configuration menu
    Copy the full SHA
    a28f722 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2022

  1. relocate rewriter.rs into pgx-utils so that we can use the `PgGuardRe…

    …writer` from build.rs.
    
    Also eliminate a bit of cloning from build.rs as well.
    
    This drastically improves pgx-pg-sys build times.
    
    On my machine, a clean build of the crate goes from ~36s to ~18s.  And subsequent rebuilds (where build.rs doesn't run) goes from ~8s to ~2.4s
    eeeebbbbrrrr committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    e4af108 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa57397 View commit details
    Browse the repository at this point in the history
  3. teach pgx that its build.rs binary should be compiled with optimiza…

    …tions, which decreases subsequent pgx-pg-sys rebuilds (where build.rs needs to run) by ~50%.
    eeeebbbbrrrr committed Apr 3, 2022
    Configuration menu
    Copy the full SHA
    738fe8b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Configuration menu
    Copy the full SHA
    aafc8f2 View commit details
    Browse the repository at this point in the history
  2. review cleanup

    eeeebbbbrrrr committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    8021953 View commit details
    Browse the repository at this point in the history
  3. oops

    eeeebbbbrrrr committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    825bc79 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Configuration menu
    Copy the full SHA
    eec3cc6 View commit details
    Browse the repository at this point in the history